-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Custom Duck.ai Onboarding - intro animation #8621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LukasPaczos
wants to merge
25
commits into
develop
Choose a base branch
from
feature/lpaczos/custom-ai-onboarding/welcome-anim
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a1c4873
Add CustomDuckAiOnboardingFeature toggle
LukasPaczos 0ff8eee
Add Duck.ai welcome intro Lottie asset
LukasPaczos 1c3c6ee
Add onboardingWelcomeIntroWith string
LukasPaczos 5784d44
Add duckAiIntroAnimation view to welcome layout (portrait)
LukasPaczos a2aeb7f
Add duckAiIntroAnimation view to welcome layout (sw600dp)
LukasPaczos ade9d50
Add duckAiIntroAnimation view to welcome layout (landscape)
LukasPaczos 80c3025
Resolve Duck.ai intro animation flag in welcome ViewModel
LukasPaczos 2384514
Fix import order
LukasPaczos f5d8e87
Play with-Duck.ai intro animation on welcome page
LukasPaczos 2b789d1
Track duckAi intro delayed runnable and cancel on destroy
LukasPaczos 2392907
Register Lottie font delegate unconditionally to avoid font asset crash
LukasPaczos fb3bf51
Gate Lottie font delegate setup behind the intro animation flag
LukasPaczos 3763f7a
attempt to fix timing and position
LukasPaczos b947e5a
Crop Duck.ai intro Lottie canvas and switch to JSON asset
LukasPaczos 475b2fc
Unify Duck.ai intro view across layouts and theme its text color
LukasPaczos 7255bdd
Extend Duck.ai intro canvas height so slide-in starts off-edge
LukasPaczos d3343af
Bump Duck.ai intro canvas height for a softer slide-in
LukasPaczos 54473a0
Size Duck.ai intro view in sp so text renders at 24sp
LukasPaczos f8fff11
Remove constrainedWidth so Duck.ai intro view scales with font size
LukasPaczos 2fa7b93
Compute Duck.ai intro view height via TypedValue so it honors non-lin…
LukasPaczos 2b08444
clean up and remove test setup
LukasPaczos 4b27771
address review comments
LukasPaczos 8ec97bc
Use a single text layer for the Duck.ai intro to avoid translation gaps
LukasPaczos c57199a
Switch Duck.ai intro to language-agnostic '+ Duck.ai' Lottie
LukasPaczos 8a15d13
Don't trigger Duck.ai intro from a cancelled intro animator
LukasPaczos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
app/src/main/java/com/duckduckgo/app/onboarding/CustomDuckAiOnboardingFeature.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * Copyright (c) 2026 DuckDuckGo | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.duckduckgo.app.onboarding | ||
|
|
||
| import com.duckduckgo.anvil.annotations.ContributesRemoteFeature | ||
| import com.duckduckgo.di.scopes.AppScope | ||
| import com.duckduckgo.feature.toggles.api.Toggle | ||
| import com.duckduckgo.feature.toggles.api.Toggle.DefaultFeatureValue | ||
|
|
||
| @ContributesRemoteFeature( | ||
| scope = AppScope::class, | ||
| featureName = "customDuckAiOnboarding", | ||
| ) | ||
| interface CustomDuckAiOnboardingFeature { | ||
|
|
||
| @Toggle.DefaultValue(DefaultFeatureValue.FALSE) | ||
| fun self(): Toggle | ||
|
|
||
| @Toggle.DefaultValue(DefaultFeatureValue.FALSE) | ||
| fun introAnimation(): Toggle | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.