Skip to content

PIR: Fix email data handling#8641

Merged
landomen merged 1 commit into
developfrom
feature/domen/pir-email-flexibility-fixes
May 26, 2026
Merged

PIR: Fix email data handling#8641
landomen merged 1 commit into
developfrom
feature/domen/pir-email-flexibility-fixes

Conversation

@landomen

@landomen landomen commented May 20, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/task/1214973541222175?focus=true

Description

Fix email data handling so email codes are properly passed along to the web layer.

Steps to test this PR

Will be testable on upstack PRs.

UI changes

No UI changes


Note

Medium Risk
Changes how opt-out/scan automation data is serialized to the in-WebView script layer; wrong mapping could break form fills or email confirmation, but scope is limited to PIR request assembly with strong unit coverage.

Overview
PIR broker script payloads now map each fillForm dataSource to its own field on UserProfile, instead of folding generated email and polled email fields into extractedProfile.

New DataSource values fetchedEmail and emailData drive completeRequestData: generated addresses go in FetchedEmail, verification codes and similar keys from getEmailData go in emailData, and extractedProfile is only populated for extractedProfile. emailExtractedData was removed from ExtractedProfileParams so the web layer can resolve data[dataSource] the way broker JSON expects.

Unit tests were updated to assert per-source isolation (e.g. verification codes are not leaked on extracted-profile fills).

Reviewed by Cursor Bugbot for commit b1d0efa. Bugbot is set up for automated code reviews on this repo. Configure here.

@landomen landomen force-pushed the feature/domen/pir-email-flexibility-fixes branch from 6d572cd to 8d8f136 Compare May 21, 2026 17:48
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-clear-on-completion branch from f6b07d2 to 73245d0 Compare May 21, 2026 17:48
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-fixes branch from 8d8f136 to 97e4aae Compare May 22, 2026 06:46
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-clear-on-completion branch from 73245d0 to 733cabf Compare May 22, 2026 06:46

@marcosholgado marcosholgado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosholgado marcosholgado self-assigned this May 25, 2026

landomen commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 26, 8:20 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 26, 9:56 AM UTC: Graphite rebased this pull request as part of a merge.
  • May 26, 10:09 AM UTC: @landomen merged this pull request with Graphite.

@landomen landomen changed the base branch from feature/domen/pir-email-flexibility-clear-on-completion to graphite-base/8641 May 26, 2026 09:42
@landomen landomen changed the base branch from graphite-base/8641 to develop May 26, 2026 09:55
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-fixes branch from 97e4aae to b1d0efa Compare May 26, 2026 09:55
@landomen landomen merged commit e520ce8 into develop May 26, 2026
13 checks passed
@landomen landomen deleted the feature/domen/pir-email-flexibility-fixes branch May 26, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants