PIR: Add getEmailData pixel#8642
Open
landomen wants to merge 5 commits into
Open
Conversation
This was referenced May 20, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1215007442176755 |
6d572cd to
8d8f136
Compare
f4d629c to
59f04e1
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 59f04e1. Configure here.
8d8f136 to
97e4aae
Compare
59f04e1 to
0a2a076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/task/1213886961787940?focus=true
Description
Add new pixels for email flexibility flow.
Steps to test this PR
Will be testable in later PRs
UI changes
No UI changes
Note
Medium Risk
Adds new pixel emissions in the PIR runner for the email-data polling stage and changes duration reporting for stage pixels, which could affect analytics accuracy and runtime behavior if state indexing is wrong.
Overview
Adds two new PIR pixels for the email-data polling stage (scan and opt-out):
m_dbp_scan_stage_email-get-dataandm_dbp_optout_stage_email-get-data, includingduration,tries, andaction_idparameters.Wires these pixels into the runner by extending
PirRunStateHandlerwith new states and updatingEmailDataReceivedEventHandlerto compute stage duration/tries/action id and emit the appropriate scan/opt-out pixel when email-extracted data arrives (skipping email-confirmation steps). Also rounds all stagedurationvalues to the nearest 10ms inPirPixelSender, and expands unit tests to cover the new pixel-emission behavior.Reviewed by Cursor Bugbot for commit 0a2a076. Bugbot is set up for automated code reviews on this repo. Configure here.