Skip to content

PIR: Add getEmailData pixel#8642

Open
landomen wants to merge 5 commits into
feature/domen/pir-email-flexibility-fixesfrom
feature/domen/pir-email-flexibility-pixels
Open

PIR: Add getEmailData pixel#8642
landomen wants to merge 5 commits into
feature/domen/pir-email-flexibility-fixesfrom
feature/domen/pir-email-flexibility-pixels

Conversation

@landomen
Copy link
Copy Markdown
Contributor

@landomen landomen commented May 20, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/task/1213886961787940?focus=true

Description

Add new pixels for email flexibility flow.

Steps to test this PR

Will be testable in later PRs

UI changes

No UI changes


Note

Medium Risk
Adds new pixel emissions in the PIR runner for the email-data polling stage and changes duration reporting for stage pixels, which could affect analytics accuracy and runtime behavior if state indexing is wrong.

Overview
Adds two new PIR pixels for the email-data polling stage (scan and opt-out): m_dbp_scan_stage_email-get-data and m_dbp_optout_stage_email-get-data, including duration, tries, and action_id parameters.

Wires these pixels into the runner by extending PirRunStateHandler with new states and updating EmailDataReceivedEventHandler to compute stage duration/tries/action id and emit the appropriate scan/opt-out pixel when email-extracted data arrives (skipping email-confirmation steps). Also rounds all stage duration values to the nearest 10ms in PirPixelSender, and expands unit tests to cover the new pixel-emission behavior.

Reviewed by Cursor Bugbot for commit 0a2a076. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor Author

landomen commented May 20, 2026

@github-actions
Copy link
Copy Markdown
Contributor

Privacy Review task: https://app.asana.com/0/69071770703008/1215007442176755

@landomen landomen force-pushed the feature/domen/pir-email-flexibility-fixes branch from 6d572cd to 8d8f136 Compare May 21, 2026 17:48
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-pixels branch from f4d629c to 59f04e1 Compare May 21, 2026 17:48
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 59f04e1. Configure here.

Comment thread pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/pixels/PirPixelSender.kt Outdated
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-fixes branch from 8d8f136 to 97e4aae Compare May 22, 2026 06:46
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-pixels branch from 59f04e1 to 0a2a076 Compare May 22, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant