PIR: Add email fallback#8656
Open
landomen wants to merge 1 commit into
Open
Conversation
This was referenced May 21, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8a7cd21 to
a454d2b
Compare
a454d2b to
438c3f9
Compare
59f04e1 to
0a2a076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/task/1214973541222181?focus=true
Description
Adds email fallback for the email confirmation job record.
Steps to test this PR
See https://app.asana.com/1/137249556945/task/1214973541222183?focus=true
UI changes
No UI changes
Note
Medium Risk
Changes the email address persisted for email-confirmation job records, which can affect downstream polling/confirmation flows if the fallback is incorrect or empty.
Overview
Ensures email-confirmation job records are populated even when an
ExtractedProfilehas no email by adding an optionalgeneratedEmailtoBrokerRecordEmailConfirmationNeededand falling back to it when marking an opt-out as waiting for confirmation.Updates
BrokerStepCompletedEventHandlerto forwardState.generatedEmailData.emailAddressinto that state, and adds tests covering both the forwarding behavior and the fallback selection logic.Reviewed by Cursor Bugbot for commit 438c3f9. Bugbot is set up for automated code reviews on this repo. Configure here.