Per-chat reasoning effort in contextual sheet#8674
Open
YoussefKeyrouz wants to merge 1 commit into
Open
Conversation
4 tasks
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
14 tasks
4d75802 to
7ce9eef
Compare
b60ace4 to
2882db3
Compare
7ce9eef to
7159e2d
Compare
2882db3 to
6f9a5f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1212810093780571/task/1215062229903137?focus=true
Description
Wires the contextual Duck.ai sheet into the per-chat reasoning flow introduced by #8666 and fixes two correctness bugs
ReasoningModePickerViewModelSteps to test this PR
Per-chat scope restored on reopen
Globals untouched
Note
Medium Risk
Moderate risk because it changes contextual sheet state management and how the native input widget resolves per-chat model/reasoning, which can affect prompt submission and session restore behavior.
Overview
Adds a
chatIdStateFlowtoDuckChatContextualViewModel, extracted from the contextual webview URL and cleared on new-chat, so the UI can reliably identify the active chat across reopen/restore flows.Wires that
chatIdinto the contextual native input path by passing achatIdFlowthroughDuckChatContextualFragment/ContextualNativeInputManagerintoNativeInputModeWidget.bindChatIdSource, enabling per-chat reasoning/model resolution in the native input picker. Includes a small correctness/cleanup tweak inReasoningModePickerViewModel(single snapshot ofmodelState) and adds unit tests coveringchatIdlifecycle (initial, restore, page-load updates, and clearing).Reviewed by Cursor Bugbot for commit 7159e2d. Bugbot is set up for automated code reviews on this repo. Configure here.