Extract Feedback feature into a separate module#9088
Open
landomen wants to merge 8 commits into
Open
Conversation
ede95df to
67c688a
Compare
67c688a to
ccdc960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1214295689610258/task/1216232692978954?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1210594645151737/task/1214800684060464?focus=true
Description
Extracts the Feedback feature from the
:appmodule into a new:feedbackmodule so it can be reused by several other features.Steps to test this PR
Smoke check Feedback and entry points
LaunchFeedbackView— whichever surface firesBrowserViewModel'sLaunchFeedbackViewcommand opens the feedback screen.AppFeedbackContract) — the "report app breakage" path launches the shared feedback intent.SubscriptionFeedbackActivity(separate flow; verify it still launches too and is not broken by the split).UI changes
No UI changes
Note
Medium Risk
Large modular refactor with many entry points; wrong wiring could break feedback launches or analytics, and About no longer exposes feedback where it did before.
Overview
Moves in-app Share Feedback out of
:appinto new:feedback-api/:feedback-implmodules and wires callers through shared navigation APIs.Launch paths:
BrowserActivity, VPN breakage (AppFeedbackContract), and similar flows now start feedback viaGlobalActivityStarterandFeedbackScreenNoParamsinstead ofFeedbackActivityin:app. Settings registersFeedbackLauncher.feedbackContract()for result-based launches and still shows the thanks snackbar; feedback copy strings move out of:applocales whilethanksForTheFeedbackstays in:appfor that snackbar.Removed from
:app: manifest entry forFeedbackActivity, app-localFeedbackContract,NetworkModulefeedback submitter wiring, and feedback submission pixel names inAppPixelName. Lint baseline drops entries for deleted feedback fragments.About screen: share-feedback commands, activity-result flow, and unified-subscription feedback routing are removed from About (Settings still handles Share Feedback with subscription unified feedback when applicable).
Reviewed by Cursor Bugbot for commit ccdc960. Bugbot is set up for automated code reviews on this repo. Configure here.