Add captcha eventHub aggregation pixel definitions#9090
Open
jdorweiler wants to merge 1 commit into
Open
Conversation
Document the day/week bucketed captcha detection pixels (recaptcha, hcaptcha, turnstile, cloudflare, other) fired by the eventHub feature. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 89811c0. Configure here.
| "type": "integer", | ||
| "description": "Unix timestamp (UTC) denoting the start of the measurement period" | ||
| } | ||
| ] |
Contributor
There was a problem hiding this comment.
Missing atb stripping for captcha pixels
Medium Severity
The ten new webTelemetry_captcha_* pixel definitions are not registered in PixelParamRemovalInterceptor (or an EventHub PixelParamRemovalPlugin). EventHub fires these names via pixel.enqueueFire, which still attaches implicit atb, so triage will reject undeclared atb once the companion privacy-config telemetry goes live.
Triggered by learned rule: New pixel definitions must handle implicit atb parameter via PixelParamRemovalInterceptor
Reviewed by Cursor Bugbot for commit 89811c0. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1216219466895942
Tech Design URL (if applicable):
Description
Goes with duckduckgo/privacy-configuration#5475
Document the day/week bucketed captcha detection pixels (recaptcha, hcaptcha, turnstile, cloudflare, other) fired by the eventHub feature.
Steps to test this PR
Feature 1
UI changes
Note
Low Risk
Schema-only pixel documentation with no runtime or client logic changes in this PR.
Overview
Adds 10 new eventHub pixel definitions in
event_hub.json5for bucketed CAPTCHA detection telemetry, mirroring the existing adwall day/week events.Each CAPTCHA category gets daily and weekly pixels: reCAPTCHA, hCaptcha, Cloudflare Turnstile, Cloudflare challenge pages, and other/generic. All use the same
count(bucketed string) andattributionPeriod(period start Unix timestamp) parameters, withothertriggers and GuiltyDolphin as owner—intended to document pixels emitted by the paired privacy-configuration eventHub work.Reviewed by Cursor Bugbot for commit 89811c0. Bugbot is set up for automated code reviews on this repo. Configure here.