PIR: Add charging constraint to PIR scheduled scan worker#9092
Open
landomen wants to merge 1 commit into
Open
Conversation
karlenDimla
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1216237628845912?focus=true
Tech Design URL (if applicable): N/A
Description
Adds back the charging constraint to PIR scheduled scan worker
Steps to test this PR
QA-optional
UI changes
No UI changes
Note
Medium Risk
Changes when periodic PIR scans can run in the background, which may delay scans for users who rarely charge but is limited to WorkManager scheduling constraints.
Overview
Restores a charging requirement on the periodic PIR scheduled scan WorkManager job in
PirScanScheduler, alongside the existing connected to run only when the device has a connected network and is plugged in.Tests assert the scheduled-scan work spec requires charging and still uses
NetworkType.CONNECTED, and that the email-confirmation periodic worker is not given a charging constraint. A shared test helper captures enqueued periodic work by tag.Reviewed by Cursor Bugbot for commit 6af100c. Bugbot is set up for automated code reviews on this repo. Configure here.