Skip to content

PIR: Add charging constraint to PIR scheduled scan worker #9092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
landomen wants to merge 1 commit into
base: develop
Choose a base branch
from
+40 −0
Open

PIR: Add charging constraint to PIR scheduled scan worker #9092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/scan/PirScanScheduler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ class RealPirScanScheduler @Inject constructor(
Constraints
.Builder()
.setRequiredNetworkType(NetworkType.CONNECTED)
.setRequiresCharging(true)
.build()

val periodicWorkRequest =
Expand Down
39 changes: 39 additions & 0 deletions pir/pir-impl/src/test/kotlin/com/duckduckgo/pir/impl/scan/RealPirScanSchedulerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package com.duckduckgo.pir.impl.scan
import android.content.Context
import androidx.test.ext.junit.runners.AndroidJUnit4
import androidx.work.ExistingPeriodicWorkPolicy
import androidx.work.NetworkType
import androidx.work.PeriodicWorkRequest
import androidx.work.WorkInfo
import androidx.work.WorkManager
Expand Down Expand Up @@ -142,6 +143,33 @@ class RealPirScanSchedulerTest {
)
}

@Test
fun whenScheduleScansThenScheduledScanWorkRequiresCharging() {
testee.scheduleScans()

val scheduledScan = capturePeriodicWorkRequests().getValue(PirScheduledScanRemoteWorker.TAG_SCHEDULED_SCAN)

assertTrue(scheduledScan.workSpec.constraints.requiresCharging())
}

@Test
fun whenScheduleScansThenScheduledScanWorkStillRequiresConnectedNetwork() {
testee.scheduleScans()

val scheduledScan = capturePeriodicWorkRequests().getValue(PirScheduledScanRemoteWorker.TAG_SCHEDULED_SCAN)

assertEquals(NetworkType.CONNECTED, scheduledScan.workSpec.constraints.requiredNetworkType)
}

@Test
fun whenScheduleScansThenEmailConfirmationWorkDoesNotRequireCharging() {
testee.scheduleScans()

val emailConfirmation = capturePeriodicWorkRequests().getValue(PirEmailConfirmationRemoteWorker.TAG_EMAIL_CONFIRMATION)

assertFalse(emailConfirmation.workSpec.constraints.requiresCharging())
}

@Test
fun whenScheduleScansThenSchedulesEmailConfirmationWorker() {
testee.scheduleScans()
Expand Down Expand Up @@ -379,4 +407,15 @@ class RealPirScanSchedulerTest {

assertFalse(testee.isScheduledScanRunning())
}

private fun capturePeriodicWorkRequests(): Map<String, PeriodicWorkRequest> {
val tagCaptor = argumentCaptor<String>()
val requestCaptor = argumentCaptor<PeriodicWorkRequest>()
verify(mockWorkManager, times(4)).enqueueUniquePeriodicWork(
tagCaptor.capture(),
any(),
requestCaptor.capture(),
)
return tagCaptor.allValues.zip(requestCaptor.allValues).toMap()
}
}
Loading