Add pixel definitions for contingency and browser menu#9097
Open
CrisBarreiro wants to merge 1 commit into
Open
Add pixel definitions for contingency and browser menu#9097CrisBarreiro wants to merge 1 commit into
CrisBarreiro wants to merge 1 commit into
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
14 tasks
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1216264345184702 |
CrisBarreiro
force-pushed
the
feature/cris/ad-blocking-pixel-triage
branch
from
3a301cf to
b3e8f2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1212227266948491/task/1216264344628719?focus=true
Description
Steps to test this PR
Feature 1
UI changes
Note
Low Risk
Analytics schema and enum additions only; no runtime behavior or user-facing logic changes in this PR.
Overview
Adds 12 new analytics pixels (daily + count pairs) for YouTube ad blocking flows from the browsing menu, not settings: re-enable from menu, opening the disable picker, picker choices (Always On, Always Off, Disable Until Relaunch), and Report Broken Site after disabling from the picker.
Registers matching names in
AdBlockingPixelNamesso the app can fire them once UI wiring lands. No emission logic is included in this diff—definitions and enum constants only.Reviewed by Cursor Bugbot for commit b3e8f2f. Bugbot is set up for automated code reviews on this repo. Configure here.