Skip to content

Add pixel definitions for contingency and browser menu #9097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CrisBarreiro wants to merge 1 commit into
base: graphite-base/9097
Choose a base branch
from
+96 −0
Open

Add pixel definitions for contingency and browser menu #9097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 84 additions & 0 deletions PixelDefinitions/pixels/definitions/ad_blocking.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,5 +132,89 @@
"triggers": ["exception"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_menu_enable_tapped_daily": {
"description": "(Daily) User tapped the 'Enable YouTube Ad Blocking' row in the browsing menu to re-enable ad blocking from a previously-disabled state.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_menu_enable_tapped_count": {
"description": "User tapped the 'Enable YouTube Ad Blocking' row in the browsing menu to re-enable ad blocking from a previously-disabled state.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_menu_disable_tapped_daily": {
"description": "(Daily) User tapped the 'Disable YouTube Ad Block' row in the browsing menu, which opens the disable mode picker.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_menu_disable_tapped_count": {
"description": "User tapped the 'Disable YouTube Ad Block' row in the browsing menu, which opens the disable mode picker.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_picker_always_on_daily": {
"description": "(Daily) User selected 'Always On' in the YouTube Ad Block disable picker.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_picker_always_on_count": {
"description": "User selected 'Always On' in the YouTube Ad Block disable picker.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_picker_always_off_daily": {
"description": "(Daily) User selected 'Always Off' in the YouTube Ad Block disable picker, persistently disabling ad blocking.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_picker_always_off_count": {
"description": "User selected 'Always Off' in the YouTube Ad Block disable picker, persistently disabling ad blocking.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_picker_disable_until_relaunch_daily": {
"description": "(Daily) User selected 'Disable Until Relaunch' in the YouTube Ad Block disable picker. The selection suppresses ad blocking for the current app session only and is not persisted to storage.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_picker_disable_until_relaunch_count": {
"description": "User selected 'Disable Until Relaunch' in the YouTube Ad Block disable picker. The selection suppresses ad blocking for the current app session only and is not persisted to storage.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_breakage_report_entered_daily": {
"description": "(Daily) User tapped 'Report Broken Site' on the breakage report prompt shown after disabling YouTube ad blocking from the browsing menu picker.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
},
"adBlocking_breakage_report_entered_count": {
"description": "User tapped 'Report Broken Site' on the breakage report prompt shown after disabling YouTube ad blocking from the browsing menu picker.",
"owners": ["CrisBarreiro"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"parameters": ["appVersion"]
}
}
12 changes: 12 additions & 0 deletions ...ing/ad-blocking-impl/src/main/java/com/duckduckgo/adblocking/impl/AdBlockingPixelNames.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,16 @@ enum class AdBlockingPixelNames(override val pixelName: String) : Pixel.PixelNam
AD_BLOCKING_SCRIPTLETS_INSTALLED_COUNT("adBlocking_scriptlets_installed_count"),
AD_BLOCKING_SCRIPTLETS_INSTALL_ERROR_DAILY("adBlocking_scriptlets_install_error_daily"),
AD_BLOCKING_SCRIPTLETS_INSTALL_ERROR_COUNT("adBlocking_scriptlets_install_error_count"),
AD_BLOCKING_MENU_ENABLE_TAPPED_DAILY("adBlocking_menu_enable_tapped_daily"),
AD_BLOCKING_MENU_ENABLE_TAPPED_COUNT("adBlocking_menu_enable_tapped_count"),
AD_BLOCKING_MENU_DISABLE_TAPPED_DAILY("adBlocking_menu_disable_tapped_daily"),
AD_BLOCKING_MENU_DISABLE_TAPPED_COUNT("adBlocking_menu_disable_tapped_count"),
AD_BLOCKING_PICKER_ALWAYS_ON_DAILY("adBlocking_picker_always_on_daily"),
AD_BLOCKING_PICKER_ALWAYS_ON_COUNT("adBlocking_picker_always_on_count"),
AD_BLOCKING_PICKER_ALWAYS_OFF_DAILY("adBlocking_picker_always_off_daily"),
AD_BLOCKING_PICKER_ALWAYS_OFF_COUNT("adBlocking_picker_always_off_count"),
AD_BLOCKING_PICKER_DISABLE_UNTIL_RELAUNCH_DAILY("adBlocking_picker_disable_until_relaunch_daily"),
AD_BLOCKING_PICKER_DISABLE_UNTIL_RELAUNCH_COUNT("adBlocking_picker_disable_until_relaunch_count"),
AD_BLOCKING_BREAKAGE_REPORT_ENTERED_DAILY("adBlocking_breakage_report_entered_daily"),
AD_BLOCKING_BREAKAGE_REPORT_ENTERED_COUNT("adBlocking_breakage_report_entered_count"),
}
Loading