Skip to content

Translations for sync exchange v2 work#9107

Open
CDRussell wants to merge 28 commits into
developfrom
feature/craig/sync_exchange_v2_l10n
Open

Translations for sync exchange v2 work#9107
CDRussell wants to merge 28 commits into
developfrom
feature/craig/sync_exchange_v2_l10n

Conversation

@CDRussell

@CDRussell CDRussell commented Jul 4, 2026

Copy link
Copy Markdown
Member

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1215945931943282?focus=true
Tech Design URL (if applicable):

Description

Steps to test this PR

Feature 1

  • [ ]
  • [ ]

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

Note

Low Risk
String-resource and translation updates only; no logic changes. Reviewers may want a quick pass on high-visibility pairing error strings in new locales.

Overview
Adds localized strings for Sync exchange v2 pairing and consent UI, and applies small Duck.ai settings copy fixes in a few locales.

Sync v2: English sync_v2_* resources move from donottranslate.xml into strings-sync.xml, with matching entries added across locale strings-sync.xml files. That covers joiner/host confirmation dialogs, DDG vs third-party data-access consent messages, pairing error/outcome text, and “already paired” states—strings already wired in sync connect/login flows.

Duck.ai: Tweaks existing translated strings only (e.g. new-tab toggle label in da/lv, “use without AI” disabled descriptions in el/fr/nb/sv).

Reviewed by Cursor Bugbot for commit 164c009. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ff95b27. Configure here.

<string name="sync_v2_confirmation_message_unknown_peer_3p">Другото устройство ще има достъп до синхронизираните Ви чатове в Duck.ai.</string>

<!-- v2 pairing terminal-outcome copy (interim, English-only). Spec 2026-06-17 (title-primary). -->
<string name="sync_v2_error_pairing_failed">Синхронизирането е успешно.</string>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bulgarian failure title says success

Medium Severity

The Bulgarian value for sync_v2_error_pairing_failed translates to a success message (“Синхронизирането е успешно.”), while the English source and other locales express failure. V2PairingError uses this string as the dialog title when pairing fails, so Bulgarian users can see a success headline on error outcomes.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ff95b27. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant