Disable open new tab with long press in NTP#9113
Open
nalcalag wants to merge 1 commit into
Open
Conversation
anikiki
approved these changes
Jul 6, 2026
anikiki
left a comment
anikiki
left a comment
Contributor
There was a problem hiding this comment.
Looks good and works as expected! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1204912272578138/task/1215861941732705?focus=true
Tech Design URL (if applicable):
Description
Disable opening a new tab with long press if already in a new tab
Steps to test this PR
New Tab Page
Browser showing
No UI changes
Note
Low Risk
Small guard in tab menu handling with no auth, data, or API changes; behavior is covered by new unit tests.
Overview
Long-pressing the tabs/new-tab control no longer opens another tab when the user is already on the new tab page (
browserShowingis false). The early return applies only to long-press; normal new-tab menu actions are unchanged.When the browser is showing a site or SERP, long-press still opens a new tab and fires
TAB_MANAGER_NEW_TAB_LONG_PRESSED. Unit tests were split to assert both behaviors.Reviewed by Cursor Bugbot for commit 6f2a622. Bugbot is set up for automated code reviews on this repo. Configure here.