Fix AppTP unregister crash#9114
Open
joshliebe wants to merge 1 commit into
Open
Conversation
95e43eb to
1d6a615
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1216284733725748?focus=true
Tech Design URL (if applicable):
Description
Steps to test this PR
Note
Low Risk
Small lifecycle guard around VPN DNS monitoring; no change to when DNS changes trigger VPN restarts.
Overview
Fixes an AppTP crash when
DnsChangeCallbackcallsunregisterNetworkCallbackwithout a matching prior registration (e.g. VPN restart/stop paths that invokeunregister()more than once or when the Moto G DNS listener was never registered).DnsChangeCallbacknow tracks aregisteredflag:register()is a no-op if already registered and only sets the flag after a successfulregisterNetworkCallback;unregister()skips when not registered and clears the flag after the unregister attempt (including on failure).Reviewed by Cursor Bugbot for commit 1d6a615. Bugbot is set up for automated code reviews on this repo. Configure here.