Skip to content

Restructure autofill UI tests, ensure critical tests are considered release blockers #9117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CDRussell wants to merge 1 commit into
base: develop
Choose a base branch
from
+43 −83
Draft

Restructure autofill UI tests, ensure critical tests are considered release blockers #9117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 0 additions & 81 deletions .github/workflows/e2e-nightly-autofill.yml
View file
Open in desktop

This file was deleted.

24 changes: 23 additions & 1 deletion .github/workflows/e2e-nightly-full-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
release_properties: ${{ secrets.FAKE_RELEASE_PROPERTIES }}
release_key: ${{ secrets.FAKE_RELEASE_KEY }}
gradle_encryption_key: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
gradle_flags: '-Pddg.di=${{ env.DDG_DI }}'
gradle_flags: '-Pautofill-disable-auth-requirement -Pddg.di=${{ env.DDG_DI }}'
develocity_access_key: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
ducksans_package_auth_user: ${{ secrets.DAXMOBILE_GITHUB_PACKAGES_AUTOMATION_USER }}
ducksans_package_auth_token: ${{ secrets.DAXMOBILE_GITHUB_PACKAGES_AUTOMATION }}
Expand Down Expand Up @@ -110,6 +110,28 @@ jobs:
test_suite_name: Release Binary Upload${{ env.DI_PAREN_SUFFIX }}
create_asana_error_task: ${{ inputs.create_asana_tasks }}

- name: Autofill Critical Path
id: maestro-autofill-critical
uses: ./.github/actions/maestro-cloud-asana-reporter
timeout-minutes: 120
with:
maestro_api_key: ${{ secrets.ROBIN_API_KEY }}
maestro_project_id: ${{ vars.ROBIN_ANDROID_PROJECT_ID }}
maestro_test_name: autofillCriticalPath${{ env.DI_UNDERSCORE_SUFFIX }}_${{ github.sha }}
maestro_timeout: ${{ vars.ROBIN_TIMEOUT_MINUTES }}
maestro_app_binary_id: ${{ steps.maestro-upload-release-binary.outputs.maestro_app_binary_id }}
maestro_api_level: 34
maestro_include_tags: autofillNoAuthTests
asana_pat: ${{ secrets.ASANA_ACCESS_TOKEN }}
asana_project_id: ${{ vars.GH_ANDROID_APP_PROJECT_ID }}
asana_section_id: ${{ vars.GH_ANDROID_APP_INCOMING_SECTION_ID }}
test_suite_name: Autofill Critical Path (${{ env.DDG_DI == 'AnvilDagger' && 'Nightly' || format('{0} Nightly', env.DDG_DI) }})
create_asana_error_task: ${{ inputs.create_asana_tasks }}
# Only block releases for the default Anvil path. Metro is informational.
is_release_blocker: ${{ env.DDG_DI == 'AnvilDagger' }}
asana_releases_project_id: ${{ vars.GH_ANDROID_APP_RELEASES_PROJECT_ID }}
asana_releases_blocker_section_id: ${{ vars.GH_ANDROID_APP_RELEASES_PROJECT_BLOCKER_SECTION_ID }}

- name: Custom tabs flows
id: maestro-custom-tabs
uses: ./.github/actions/maestro-cloud-asana-reporter
Expand Down
21 changes: 20 additions & 1 deletion .github/workflows/e2e-nightly-non-blockers-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
gradle_encryption_key: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
# Disable the 50/50 onboardingQuickSetupExperimentJun3 A/B experiment so the
# preonboarding tests don't randomly fail when enrolled in the TREATMENT cohort
gradle_flags: '-Pconfig_patches=.maestro/onboarding/remote_config_patches/disable_onboarding_quick_setup_experiment.json,.maestro/duckplayer/patches/ad_blocking_enabled_patch.json'
gradle_flags: '-Pautofill-disable-auth-requirement -Pconfig_patches=.maestro/onboarding/remote_config_patches/disable_onboarding_quick_setup_experiment.json,.maestro/duckplayer/patches/ad_blocking_enabled_patch.json'
develocity_access_key: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
ducksans_package_auth_user: ${{ secrets.DAXMOBILE_GITHUB_PACKAGES_AUTOMATION_USER }}
ducksans_package_auth_token: ${{ secrets.DAXMOBILE_GITHUB_PACKAGES_AUTOMATION }}
Expand Down Expand Up @@ -70,6 +70,25 @@ jobs:
asana_section_id: ${{ vars.GH_ANDROID_APP_INCOMING_SECTION_ID }}
test_suite_name: Release Binary Upload

- name: Autofill Web Flows
id: maestro-autofill-web
# Run regardless of earlier suite failures, but only if the release binary uploaded.
if: ${{ !cancelled() && steps.maestro-upload-release-binary.outcome == 'success' }}
uses: ./.github/actions/maestro-cloud-asana-reporter
timeout-minutes: 120
with:
maestro_api_key: ${{ secrets.ROBIN_API_KEY }}
maestro_project_id: ${{ vars.ROBIN_ANDROID_PROJECT_ID }}
maestro_test_name: autofill_secondary_functionality_${{ github.sha }}
maestro_timeout: ${{ vars.ROBIN_TIMEOUT_MINUTES }}
maestro_app_binary_id: ${{ steps.maestro-upload-release-binary.outputs.maestro_app_binary_id }}
maestro_api_level: 34
maestro_include_tags: autofillBackfillingUsername,autofillPasswordGeneration
asana_pat: ${{ secrets.ASANA_ACCESS_TOKEN }}
asana_project_id: ${{ vars.GH_ANDROID_APP_PROJECT_ID }}
asana_section_id: ${{ vars.GH_ANDROID_APP_INCOMING_SECTION_ID }}
test_suite_name: Autofill Web Flows

- name: Run Duck Player Maestro Tests
id: maestro-cloud-asana
# Run regardless of earlier suite failures, but only if the internal binary uploaded.
Expand Down
Loading