Use BloomFilter.xcframework binary dependency#1269
Merged
Conversation
samsymons
approved these changes
Jul 11, 2025
Collaborator
samsymons
left a comment
samsymons
left a comment
There was a problem hiding this comment.
Looks great, thanks so much for doing this!
mallexxx
added a commit
to duckduckgo/bloom_cpp
that referenced
this pull request
Jul 17, 2025
prepare_release.sh script building and uploading xcframework Task/Issue URL: https://app.asana.com/1/137249556945/project/1203301625297703/task/1210725543567479?focus=true macOS PR: duckduckgo/apple-browsers#1269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1203301625297703/task/1210725543567479?focus=true
Bloom_cpp PR: duckduckgo/bloom_cpp#27
Description
Testing Steps
Impact and Risks
What could go wrong?
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template