Skip to content

Add Maestro E2E tests for autocomplete fill arrow and history delete#5205

Open
dus7 wants to merge 1 commit into
mainfrom
mariusz/autocomplete-e2e-test
Open

Add Maestro E2E tests for autocomplete fill arrow and history delete#5205
dus7 wants to merge 1 commit into
mainfrom
mariusz/autocomplete-e2e-test

Conversation

@dus7
Copy link
Copy Markdown
Contributor

@dus7 dus7 commented Jun 1, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/414709148257752/task/1214603625531199
Tech Design URL:
CC:

Description

Adds a Maestro flow covering the autocomplete suggestion accessory controls: the tap-ahead "fill" arrow on a search-phrase suggestion, and the delete button on a history suggestion. The fill arrow regressed previously (tapping did nothing), so the test taps it and asserts the address-bar query changes without navigating.

To make both controls addressable by Maestro, the suggestion row now isolates its accessibility identifiers. The row is wrapped in a Button, whose accessibility element would otherwise absorb the trailing buttons and propagate the row identifier onto every child, so the icon and title are combined into a single element that carries the row identifier, leaving the tap-ahead and delete buttons as separate siblings with their own identifiers.

Testing Steps

  1. Run .maestro/release_tests/autocomplete.yaml and verify it passes.
  2. Verify the autocomplete rows design is unchanged and works as expected.

Impact and Risks

Medium. The change is an accessibility-identifier reorganization on the autocomplete row plus a new test; UI needed some adjustments to allow this to work.

What could go wrong?

View modification was required to add an accessibility id for nested items in a button. UI may be off or not functional.

Quality Considerations

N/A

Notes to Reviewer

Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Medium Risk
Restructures SwiftUI accessibility on autocomplete rows inside a Button wrapper; low logic change but possible UI/tap or VoiceOver regressions on suggestion accessories.

Overview
Adds a release Maestro flow (autocomplete.yaml) that exercises autocomplete accessory actions: the search-phrase tap-ahead control must expand the address-bar query without leaving edit mode, and the history delete control must remove the matching suggestion row.

In AutocompleteView, suggestion rows now pass accessibilityIdentifier into SuggestionListItem and apply it to a combined icon/title accessibility element so the enclosing list Button no longer collapses identifiers onto the trailing controls. Dedicated IDs are set on Autocomplete.Suggestions.ListItem.TapAheadButton and DeleteButton so automation can target those accessories separately from the row.

Reviewed by Cursor Bugbot for commit e07a932. Bugbot is set up for automated code reviews on this repo. Configure here.

@dus7 dus7 marked this pull request as ready for review June 1, 2026 15:11
@dus7 dus7 requested a review from brindy June 1, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants