Add Maestro E2E tests for autocomplete fill arrow and history delete#5205
Open
dus7 wants to merge 1 commit into
Open
Add Maestro E2E tests for autocomplete fill arrow and history delete#5205dus7 wants to merge 1 commit into
dus7 wants to merge 1 commit into
Conversation
brindy
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/414709148257752/task/1214603625531199
Tech Design URL:
CC:
Description
Adds a Maestro flow covering the autocomplete suggestion accessory controls: the tap-ahead "fill" arrow on a search-phrase suggestion, and the delete button on a history suggestion. The fill arrow regressed previously (tapping did nothing), so the test taps it and asserts the address-bar query changes without navigating.
To make both controls addressable by Maestro, the suggestion row now isolates its accessibility identifiers. The row is wrapped in a
Button, whose accessibility element would otherwise absorb the trailing buttons and propagate the row identifier onto every child, so the icon and title are combined into a single element that carries the row identifier, leaving the tap-ahead and delete buttons as separate siblings with their own identifiers.Testing Steps
.maestro/release_tests/autocomplete.yamland verify it passes.Impact and Risks
Medium. The change is an accessibility-identifier reorganization on the autocomplete row plus a new test; UI needed some adjustments to allow this to work.
What could go wrong?
View modification was required to add an accessibility id for nested items in a button. UI may be off or not functional.
Quality Considerations
N/A
Notes to Reviewer
—
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Medium Risk
Restructures SwiftUI accessibility on autocomplete rows inside a
Buttonwrapper; low logic change but possible UI/tap or VoiceOver regressions on suggestion accessories.Overview
Adds a release Maestro flow (
autocomplete.yaml) that exercises autocomplete accessory actions: the search-phrase tap-ahead control must expand the address-bar query without leaving edit mode, and the history delete control must remove the matching suggestion row.In
AutocompleteView, suggestion rows now passaccessibilityIdentifierintoSuggestionListItemand apply it to a combined icon/title accessibility element so the enclosing listButtonno longer collapses identifiers onto the trailing controls. Dedicated IDs are set onAutocomplete.Suggestions.ListItem.TapAheadButtonandDeleteButtonso automation can target those accessories separately from the row.Reviewed by Cursor Bugbot for commit e07a932. Bugbot is set up for automated code reviews on this repo. Configure here.