Skip to content

[CI][PR Subtask] Add PR author as collaborator to PR subtask #5218

Merged
alessandroboron merged 2 commits into
mainfrom
alessandro/apple-proposal-improve-collaborator-communication
Jun 3, 2026
Merged

[CI][PR Subtask] Add PR author as collaborator to PR subtask #5218
alessandroboron merged 2 commits into
mainfrom
alessandro/apple-proposal-improve-collaborator-communication

Conversation

@alessandroboron
Copy link
Copy Markdown
Contributor

@alessandroboron alessandroboron commented Jun 2, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1206329551987282/task/1215310281455434?focus=true
Tech Design URL:
CC:

Description

This PR adds the PR author as a collaborator to each PR review task, so that comments/updates in the PR review task are automatically surfaced in their inbox.

This PR depends on Apple Toolbox PR duckduckgo/apple-toolbox#18

Testing Steps

  1. Ensure that the author of this PR (me) gets added to the PR task URL.

Impact and Risks

What could go wrong?

Quality Considerations

Notes to Reviewer


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Low Risk
Internal CI wiring only; no app or user-facing runtime changes, though subtask collaborator assignment depends on the external apple-toolbox release.

Overview
When a reviewer is requested on a PR, the Create or Update PR Subtask step in create_asana_pr_subtask.yml now passes the pull request author's GitHub login and user type into duckduckgo/apple-toolbox’s asana-create-pr-subtask action (alongside the existing reviewer mapping). That lets the toolbox action add the PR author as a collaborator on the Asana PR review subtask so task comments and updates show up in their inbox.

Behavior still runs only on review_requested and still depends on the companion change in apple-toolbox for the new inputs to take effect.

Reviewed by Cursor Bugbot for commit cc92420. Bugbot is set up for automated code reviews on this repo. Configure here.

@alessandroboron alessandroboron requested a review from samsymons June 2, 2026 05:36
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit af853df. Configure here.

Comment thread .github/workflows/create_asana_pr_subtask.yml Outdated
@alessandroboron alessandroboron requested review from samsymons and removed request for samsymons June 2, 2026 05:40
Comment on lines 32 to +33
github-reviewer-user: ${{ github.event.requested_reviewer.login }}
github-pr-author-user: ${{ github.event.pull_request.user.login }}
Copy link
Copy Markdown
Collaborator

@samsymons samsymons Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly I noticed that while you are now correctly added a collaborator, somehow I was not, even though the task is assigned to me. This behavior is still fine since it achieves the goal (the PR author is now notified when the task is marked complete) so I'm not sure this is actually an issue - maybe it will mean that if you comment on the PR review task, I won't see it?

Feel free to add a comment on the PR review task and ping me when you did so, I'll check whether I got notified. If I didn't we should update the automation to also add the reviewer as a collaborator.

Copy link
Copy Markdown
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment about something I'm not sure is an issue. Overall though this does achieve the success criteria so it's all good - feel free to merge the upstream apple-toolbox PR then merge this. Thanks!

@alessandroboron alessandroboron force-pushed the alessandro/apple-proposal-improve-collaborator-communication branch from 8a5296e to cc92420 Compare June 3, 2026 00:26
@alessandroboron
Copy link
Copy Markdown
Contributor Author

Left one comment about something I'm not sure is an issue. Overall though this does achieve the success criteria so it's all good - feel free to merge the upstream apple-toolbox PR then merge this. Thanks!

Thanks Sam, I will fix it in the subsequent PR.

@alessandroboron alessandroboron merged commit 3ee96ea into main Jun 3, 2026
58 checks passed
@alessandroboron alessandroboron deleted the alessandro/apple-proposal-improve-collaborator-communication branch June 3, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants