Bump piggieback and nrepl

[viesti]

Allows using Leiningen 2.9.1.

cljs-repl would need similar upgrade to figwheel-sidecar (bhauman/lein-figwheel#730), but changes in this PR should help getting Leiningen 2.9.1 into in older projects.

[weavejester]

Thanks for the PR. Can you change the commit message to:

Update Piggieback and nREPL

Allows use with Leiningen 2.9.1.

[viesti]

Thanks for the clarification!

I missed providing context for the change, so better late than never, I guess :)

I didn't yet find the exact problem, but this upgrade at least removes the following on Leinigen 2.9.1:

0% lein --version
Leiningen 2.9.1 on Java 1.8.0_191 Java HotSpot(TM) 64-Bit Server VM
0% lein repl
2019-03-24 16:09:32.780:INFO::main: Logging initialized @13824ms
[WARNING] No nREPL middleware descriptor in metadata of #'cemerick.piggieback/wrap-cljs-repl, see nrepl.middleware/set-descriptor!
nREPL server started on port 56115 on host 127.0.0.1 - nrepl://127.0.0.1:56115
ERROR: Unhandled REPL handler exception processing message {:id e9e6f122-46e2-41a0-b174-658b67be6b83, :op clone}
java.lang.NullPointerException
	at clojure.core$deref_future.invokeStatic(core.clj:2208)
	at clojure.core$deref.invokeStatic(core.clj:2228)
	at clojure.core$deref.invoke(core.clj:2214)
	at cemerick.piggieback$wrap_cljs_repl$fn__11136.invoke(piggieback.clj:288)
	at clojure.tools.nrepl.middleware$wrap_conj_descriptor$fn__2796.invoke(middleware.clj:22)
	at nrepl.server$handle_STAR_.invokeStatic(server.clj:18)
	at nrepl.server$handle_STAR_.invoke(server.clj:15)
	at nrepl.server$handle$fn__31097.invoke(server.clj:27)
	at clojure.core$binding_conveyor_fn$fn__4676.invoke(core.clj:1938)
	at clojure.lang.AFn.call(AFn.java:18)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

I guess the root of the problem relates to the organisation change. I think the way out is to upgrade to modern nrepl (and middleware), as suggested by nrepl troubleshooting documentation.

[viesti]

Thanks for merging!

I wonder if it would be possible to cut a 0.3.4 release, it would make it easier to transition to Leiningen 2.9.1 in one of my projects :)

[viesti]

A friendly nudge on the 0.3.4 release with these changes :) This would allow me to upgrade to Leiningen 2.9.1 in a client project.

[weavejester]

Done. Sorry for the wait.

[viesti]

Awesome! No problem with the wait, thank you for your work! :)