Skip to content

Adding sound support via soundcmd in config.h #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Binkersss wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding sound support via soundcmd in config.h #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b49a455
Adding sound support via soundcmd in config.h
Binkersss Feb 13, 2026
8e9f4c1
Adding early return guard to gracefully handle NULL soundcmd
Binkersss Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config.def.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,7 @@ enum corners corner = TOP_RIGHT;

static const unsigned int duration = 5; /* in seconds */

static const char *soundcmd[] = { NULL }; /* NULL for no sound */

#define DISMISS_BUTTON Button1
#define ACTION_BUTTON Button3
16 changes: 15 additions & 1 deletion herbe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,18 @@ void expire(int sig)
XFlush(display);
}

static void playsound(void)
{
if (soundcmd[0] == NULL) return;

/* Forking to avoid delay */
if (fork() == 0) {
setsid();
execvp(soundcmd[0], (char *const *)soundcmd);
_exit(1);
}
}

int main(int argc, char *argv[])
{
if (argc == 1)
Expand Down Expand Up @@ -171,6 +183,8 @@ int main(int argc, char *argv[])
XSelectInput(display, window, ExposureMask | ButtonPress);
XMapWindow(display, window);

playsound();

sem_t *mutex = sem_open("/herbe", O_CREAT, 0644, 1);
sem_wait(mutex);

Expand Down Expand Up @@ -217,4 +231,4 @@ int main(int argc, char *argv[])
XCloseDisplay(display);

return exit_code;
}
}