Skip to content

Commit 800ec73

Browse files
authored
chore: drop noqa comments and blob_storage.is_enabled (#65)
No linter is configured in this repo so the noqa hints were just ceremony. Removed across app.py and lambda_handlers/. is_enabled() existed to skip S3 when PACKAGE_DATA_BUCKET wasn't set (legacy local-dev escape hatch). Now that /data is gone and /blob is the only data path, S3 is required everywhere; missing the env should fail loudly, not 501 quietly.
1 parent f30aae8 commit 800ec73

4 files changed

Lines changed: 7 additions & 15 deletions

File tree

src/app.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from flask_limiter import Limiter
77

88
# Import tasks before db so dotenv loads before SQLAlchemy reads POSTGRES_URL.
9-
import tasks # noqa: F401
9+
import tasks
1010
from enqueue import enqueue_package
1111
from db import PackageProcessStatus, SavedPackageData, Session, fetch_package_status, fetch_package_rank
1212

@@ -212,10 +212,6 @@ def get_package_blob(package_id):
212212
import blob_storage
213213
from db import SavedPackageData
214214

215-
if not blob_storage.is_enabled():
216-
# /blob requires S3. Local dev should use /data.
217-
return jsonify({'errorMessageCode': 'S3_NOT_CONFIGURED'}), 501
218-
219215
ttl = int(os.getenv('PACKAGE_DATA_PRESIGNED_URL_TTL_SECONDS', '300'))
220216

221217
# Demo: unauthenticated, lazy-seed S3 from generate_demo_database() on the

src/blob_storage.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
download directly from S3 — bypassing API Gateway, which is slow and
66
6MB-capped for binary responses.
77
8-
No-op when PACKAGE_DATA_BUCKET is unset (local dev): callers fall back
9-
to the legacy DB-backed path.
8+
PACKAGE_DATA_BUCKET must be set; the /blob endpoint requires S3.
109
"""
1110
import os
1211

@@ -15,9 +14,6 @@ def _bucket():
1514
return os.getenv("PACKAGE_DATA_BUCKET")
1615

1716

18-
def is_enabled() -> bool:
19-
return bool(_bucket())
20-
2117

2218
def _key(package_id: str) -> str:
2319
# Flat layout. Package IDs are MD5 hex digests, so no path-traversal risk.

src/lambda_handlers/api.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
# keep working when this module is loaded from `src/lambda_handlers/api.py`.
77
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
88

9-
import secrets_loader # noqa: F401, E402 — runs at import to fetch SM secrets into os.environ
10-
from apig_wsgi import make_lambda_handler # noqa: E402
11-
from app import app # noqa: E402
9+
import secrets_loader
10+
from apig_wsgi import make_lambda_handler
11+
from app import app
1212

1313
handler = make_lambda_handler(app)

src/lambda_handlers/worker.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414

1515
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
1616

17-
import secrets_loader # noqa: F401, E402 — runs at import to fetch SM secrets into os.environ
18-
from tasks import process_package # noqa: E402
17+
import secrets_loader
18+
from tasks import process_package
1919

2020

2121
def handler(event, context):

0 commit comments

Comments
 (0)