chore: drop /data endpoint and server-side decryption#64
Merged
Conversation
Now that the frontend uses /blob + client-side decryption (PR #402 in dumpus-app), the /data endpoint, server-side decrypt_sqlite_data, the fetch_package_data helper, and the rm_demo() module-load hack are all dead code. Strip them. Schema cleanup: encrypted_data column on saved_package_data is dropped via an idempotent ALTER TABLE … DROP COLUMN IF EXISTS that runs on Lambda cold start. Only the iv stays in Postgres now. Updates the README's API documentation accordingly. Implements the README's stated security model — 'encryption key must always remain on the client side, must never be stored on the server side' — for the first time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that frontend PR #402 (dumpus-app) uses /blob + client-side decryption, the /data endpoint, server-side decrypt_sqlite_data, fetch_package_data, and the rm_demo() module-load hack are all dead code.
This:
The README's claim that 'the encryption key must always remain on the client side, must never be stored on the server side' is now actually true.
Order of deploy
Backend first (this PR), then frontend (#402). With this merged + deployed:
Test plan