Track when error happens (#22)

* Track when error happens

* added few tests

* install.sh script updates

Author: ivpusic

cli/root.go

@@ -8,6 +8,11 @@ import (
 	"time"
 
 	"github.com/charmbracelet/fang"
+	"github.com/spf13/cobra"
+
+	"github.com/duneanalytics/duneapi-client-go/config"
+	"github.com/duneanalytics/duneapi-client-go/dune"
+
 	"github.com/duneanalytics/cli/authconfig"
 	"github.com/duneanalytics/cli/cmd/auth"
 	duneconfig "github.com/duneanalytics/cli/cmd/config"
@@ -18,9 +23,6 @@ import (
 	"github.com/duneanalytics/cli/cmd/usage"
 	"github.com/duneanalytics/cli/cmdutil"
 	"github.com/duneanalytics/cli/tracking"
-	"github.com/duneanalytics/duneapi-client-go/config"
-	"github.com/duneanalytics/duneapi-client-go/dune"
-	"github.com/spf13/cobra"
 )
 
 var apiKeyFlag string
@@ -126,9 +128,40 @@ func Execute(version, commit, date, amplitudeKey string) {
 	if err := fang.Execute(rootCmd.Context(), rootCmd,
 		fang.WithVersion(versionStr),
 	); err != nil {
-		tracker.Track("unknown", tracking.StatusError, err.Error(), 0)
+		// Build best-effort command path from os.Args (strip flags).
+		commandPath := commandPathFromArgs(os.Args)
+		tracker.Track(commandPath, tracking.StatusError, err.Error(), 0)
+		// Flush the event before exiting — os.Exit does not run deferred funcs,
+		// so defer tracker.Shutdown() above would never fire.
+		tracker.Shutdown()
 
 		fmt.Fprintln(os.Stderr, err)
 		os.Exit(1)
 	}
 }
+
+// commandPathFromArgs extracts the subcommand path from os.Args, skipping
+// the binary name, flags, and flag values so the tracked path is e.g.
+// "query list" even when invoked as "dune --api-key KEY query list --limit 10".
+func commandPathFromArgs(args []string) string {
+	var parts []string
+	skipNext := false
+	for _, a := range args[1:] { // skip binary name
+		if skipNext {
+			skipNext = false
+			continue
+		}
+		if strings.HasPrefix(a, "-") {
+			// --flag=value is self-contained; --flag value needs to skip the next arg.
+			if !strings.Contains(a, "=") {
+				skipNext = true
+			}
+			continue
+		}
+		parts = append(parts, a)
+	}
+	if len(parts) == 0 {
+		return "unknown"
+	}
+	return strings.Join(parts, " ")
+}

cli/root_test.go

@@ -69,3 +69,58 @@ func TestPersistentPreRunEConfigFallback(t *testing.T) {
 	err := rootCmd.PersistentPreRunE(cmd, nil)
 	require.NoError(t, err)
 }
+
+func TestCommandPathFromArgs(t *testing.T) {
+	tests := []struct {
+		name string
+		args []string
+		want string
+	}{
+		{
+			name: "simple subcommand",
+			args: []string{"dune", "query", "list"},
+			want: "query list",
+		},
+		{
+			name: "root flag before subcommand",
+			args: []string{"dune", "--api-key", "KEY", "query", "list"},
+			want: "query list",
+		},
+		{
+			name: "flag with equals syntax",
+			args: []string{"dune", "--api-key=KEY", "query", "list"},
+			want: "query list",
+		},
+		{
+			name: "trailing flags after subcommand",
+			args: []string{"dune", "query", "list", "--limit", "10"},
+			want: "query list",
+		},
+		{
+			name: "flags before and after subcommand",
+			args: []string{"dune", "--api-key", "KEY", "query", "list", "--limit", "10"},
+			want: "query list",
+		},
+		{
+			name: "binary only",
+			args: []string{"dune"},
+			want: "unknown",
+		},
+		{
+			name: "only flags",
+			args: []string{"dune", "--help"},
+			want: "unknown",
+		},
+		{
+			name: "single subcommand",
+			args: []string{"dune", "auth"},
+			want: "auth",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equal(t, tt.want, commandPathFromArgs(tt.args))
+		})
+	}
+}

install.sh

@@ -3,7 +3,7 @@
 # Usage: curl -sSfL https://github.com/duneanalytics/cli/raw/main/install.sh | bash
 #
 # Environment variables:
-#   INSTALL_DIR  — installation directory (default: /usr/local/bin)
+#   INSTALL_DIR  — override installation directory (default: auto-detected)
 #   VERSION      — specific version to install (default: latest)
 #   GITHUB_TOKEN — GitHub token for private repo access
 
@@ -30,7 +30,11 @@ main() {
     # Strip leading 'v' for archive name
     version_num="${version#v}"
 
-    install_dir="${INSTALL_DIR:-/usr/local/bin}"
+    if [ -n "$INSTALL_DIR" ]; then
+        install_dir="$INSTALL_DIR"
+    else
+        install_dir=$(detect_install_dir)
+    fi
 
     case "$os" in
         windows) ext="zip" ;;
@@ -68,16 +72,39 @@ main() {
 
     chmod +x "$tmp/$binary_name"
 
+    mkdir -p "$install_dir" 2>/dev/null || true
+
     if [ -w "$install_dir" ]; then
         mv "$tmp/$binary_name" "$install_dir/$binary_name"
     else
         log "Installing to ${install_dir} (requires sudo)..."
+        sudo mkdir -p "$install_dir"
         sudo mv "$tmp/$binary_name" "$install_dir/$binary_name"
     fi
 
     log "Installed ${BINARY} ${version} to ${install_dir}/${binary_name}"
 }
 
+# Pick the best install directory by checking user-writable directories
+# already on PATH, falling back to /usr/local/bin (always on PATH).
+detect_install_dir() {
+    for candidate in \
+        "$HOME/.local/bin" \
+        "$HOME/bin" \
+        "$HOME/go/bin" \
+        "$HOME/.cargo/bin"; do
+        case ":$PATH:" in
+            *":${candidate}:"*)
+                if [ -d "$candidate" ] && [ -w "$candidate" ]; then
+                    echo "$candidate"
+                    return
+                fi
+                ;;
+        esac
+    done
+    echo "/usr/local/bin"
+}
+
 detect_os() {
     os=$(uname -s | tr '[:upper:]' '[:lower:]')
     case "$os" in