Timeout and help improvements#15
Conversation
PR SummaryMedium Risk Overview Extends Written by Cursor Bugbot for commit ea255e4. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated CLI command metadata and help text across many commands; added configurable timeout, --no-wait, and polling behavior for execution results; wired timeout through SQL and query run flows; added PollInterval and centralized results handling; test coverage updated for no-wait and polling scenarios. Changes
Sequence Diagram(s)sequenceDiagram
participant CLI as CLI (user)
participant Cmd as Command Logic
participant SDK as Dune Client (SDK)
participant API as Dune API
CLI->>Cmd: run results command (--no-wait / --timeout)
Cmd->>SDK: Request execution results (QueryExecute or RunQuery)
SDK->>API: HTTP call to results endpoint /execute
API-->>SDK: Returns execution state (PENDING / EXECUTING / COMPLETED / FAILED)
alt wait mode (no --no-wait is false)
loop poll until timeout or COMPLETED
Cmd->>SDK: WaitGetResults (poll)
SDK->>API: Poll results endpoint
API-->>SDK: Updated state
end
SDK-->>Cmd: Final results or error
else no-wait
SDK-->>Cmd: Immediate response (current state / partial results)
end
Cmd->>CLI: Render results / error via handleResultsResponse
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.5.0)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
Merge the detailed flag descriptions from PR #15 (max lengths, type format hints, behavioral details, category explanations) with the examples and Long descriptions from the search_by_contract work. Every Short, Long, and flag help string is now maximally descriptive so AI agents can select the right commands and flags without ambiguity.
Merge the detailed flag descriptions from PR #15 (max lengths, type format hints, behavioral details, category explanations) with the examples and Long descriptions from the search_by_contract work. Every Short, Long, and flag help string is now maximally descriptive so AI agents can select the right commands and flags without ambiguity.
* Add search by contract functionality * Enrich command and flag descriptions for AI agent consumption Merge the detailed flag descriptions from PR #15 (max lengths, type format hints, behavioral details, category explanations) with the examples and Long descriptions from the search_by_contract work. Every Short, Long, and flag help string is now maximally descriptive so AI agents can select the right commands and flags without ambiguity.
Added
--timeoutoption and improved command and option descriptions to be more agent friendly.