Skip to content

Skip auth prompt in install.sh if already authenticated#25

Merged
ivpusic merged 1 commit into
mainfrom
dont_reauthenticate
Mar 11, 2026
Merged

Skip auth prompt in install.sh if already authenticated#25
ivpusic merged 1 commit into
mainfrom
dont_reauthenticate

Conversation

@ivpusic
Copy link
Copy Markdown
Member

@ivpusic ivpusic commented Mar 11, 2026

Summary

  • Before prompting the user to authenticate during install, check if they're already authenticated by running dune usage
  • If the check succeeds, print "Already authenticated with Dune." and skip the auth prompt entirely
  • Avoids unnecessary re-authentication on reinstalls/upgrades

@cursor
Copy link
Copy Markdown

cursor Bot commented Mar 11, 2026

PR Summary

Low Risk
Low risk: small shell-script change limited to post-install UX, with the only behavior change being conditional suppression of the auth prompt based on dune usage exit status.

Overview
Updates install.sh post-install flow to first probe authentication by running dune usage; if it succeeds, the script logs Already authenticated with Dune. and skips the interactive dune auth prompt.

Otherwise, the existing authentication prompt and dune auth invocation remain unchanged.

Written by Cursor Bugbot for commit a02c499. Configure here.

Copy link
Copy Markdown

@va3093 va3093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, can you sync with platform on what merge rules we need to have.

You shouldn't be able to merge this without a review.

Image

@ivpusic ivpusic merged commit d1ef505 into main Mar 11, 2026
3 checks passed
@ivpusic ivpusic deleted the dont_reauthenticate branch March 11, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants