Skip to content

Commit 7fdcee5

Browse files
committed
Fix manifest download workflow selection
1 parent a222c62 commit 7fdcee5

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/dbt_ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,14 @@ jobs:
4949
continue-on-error: true
5050
# Using dawidd6/action-download-artifact instead of actions/download-artifact
5151
# because the official action only downloads artifacts from the same workflow run,
52-
# while we need to download the manifest from the most recent successful dbt_deploy run.
52+
# while we need to download the manifest from the most recent completed dbt_deploy run.
5353
uses: dawidd6/action-download-artifact@v6
5454
with:
5555
name: prod-manifest-latest
5656
path: ./state
5757
workflow: dbt_deploy.yml
5858
branch: main
59+
workflow_conclusion: completed # Include failed deploys that still uploaded a current manifest.
5960
if_no_artifact_found: ignore # Let our verification step handle the error with detailed message
6061

6162
- name: Verify manifest exists

.github/workflows/dbt_deploy.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,14 @@ jobs:
5353
continue-on-error: true
5454
# Using dawidd6/action-download-artifact instead of actions/download-artifact
5555
# because the official action only downloads artifacts from the same workflow run,
56-
# while we need to download the manifest from the most recent successful run of this workflow.
56+
# while we need to download the manifest from the most recent completed run of this workflow.
5757
uses: dawidd6/action-download-artifact@v6
5858
with:
5959
name: prod-manifest-latest
6060
path: ./state
6161
workflow: dbt_deploy.yml
6262
branch: main
63+
workflow_conclusion: completed # Include failed deploys that still uploaded a current manifest.
6364
if_no_artifact_found: warn
6465

6566
- name: Compile current models
@@ -104,4 +105,3 @@ jobs:
104105
path: target/manifest.json
105106
retention-days: 90
106107
overwrite: true # overwrite the artifact with the latest manifest, ensures only one artifact is uploaded
107-

0 commit comments

Comments
 (0)