feat: only flag resources when status indicates problems and are not …#12
Open
millaguie wants to merge 2 commits into
Open
feat: only flag resources when status indicates problems and are not …#12millaguie wants to merge 2 commits into
millaguie wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…suppressed
The previous way of declaring the metric would flag many resources as the default status for the check. In my use case, which is probably not the default, I have accepted some resources to have issues in Trust Advisor and I also know that I have a fluctuating number of resources that is okay to fail on each issue, so I can create rules to flag alerts only when those levels are exceeded.
I think this is clearer.