fix(balancer): resolve ERC4626 wrappers to underlying in v3 trades#9694
Draft
kkqzhou wants to merge 1 commit into
Draft
fix(balancer): resolve ERC4626 wrappers to underlying in v3 trades#9694kkqzhou wants to merge 1 commit into
kkqzhou wants to merge 1 commit into
Conversation
The v3 macro already substituted underlying amounts from matched Wrap/Unwrap events but kept the wrapped (wn*) token addresses, leaving rows internally inconsistent (underlying amount, wrapped address) and unpriceable downstream in dex.trades. Substitute the address too when wrap/unwrap matched and the ERC4626 mapping has the underlying. Also seed wnWMON -> WMON on Monad, which never appears in Vault_evt_LiquidityAddedToBuffer and so was missing from the auto-derived mapping. Recovers ~\$2.4M/day of previously NULL-priced volume in monad balancer dex.trades. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
github-actions
Bot
added
WIP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v3 macro already substituted underlying amounts from matched Wrap/Unwrap events but kept the wrapped (wn*) token addresses, leaving rows internally inconsistent (underlying amount, wrapped address) and unpriceable downstream in dex.trades.
Substitute the address too when wrap/unwrap matched and the ERC4626 mapping has the underlying. Also seed wnWMON -> WMON on Monad, which never appears in Vault_evt_LiquidityAddedToBuffer and so was missing from the auto-derived mapping. Recovers ~$2.4M/day of previously NULL-priced volume in monad balancer dex.trades.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: