Skip to content

fix: drop deprecated goerli models causing prod failures#9712

Merged
jeff-dude merged 4 commits into
mainfrom
alice/remove-hourly-goerli-models
Jun 3, 2026
Merged

fix: drop deprecated goerli models causing prod failures#9712
jeff-dude merged 4 commits into
mainfrom
alice/remove-hourly-goerli-models

Conversation

@alicecha

@alicecha alicecha commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Prod hourly dbt run is failing because the deprecated decoded goerli schemas (gnosis_safe_goerli, zora_goerli, erc721_goerli, erc1155_goerli, tokens_goerli, nft_goerli) no longer exist in DuneSQL — goerli testnet was sunset. Visible errors: SCHEMA_NOT_FOUND on gnosis_safe_goerli, TABLE_NOT_FOUND on delta_prod.zora_goerli.erc721drop_evt_sale (full run: ERROR=4 SKIP=12).

The raw goerli chain schema (transactions/traces) is still active per Amplitude (~15–30 query executions/day) and is left untouched. All decoded goerli schemas have 0 queries in the last 180 days per Amplitude, and the spell outputs we're removing have 0–1 queries in that same window — safe to delete.

Changes by subproject

hourly_spellbook — primary fix
Removes the 10 goerli models + their tests, the safe_goerli schema entry in dbt_project.yml, and strips goerli refs from the umbrella aggregators (safe_*_all, nft_transfers, nft_approvals, zora_mints) plus blockchain/tag lists.

  • Strictly required (block the immediate failure): safe_goerli_{singletons,safes,transactions,eth_transfers}, zora_goerli_mints.
  • Cleanup beyond the immediate failure — orphaned (umbrella aggregators already don't ref them) and depending on deprecated decoded sources: addresses_events_goerli_{first_activity,first_funded_by,first_token_received}, nft_goerli_{transfers,approvals}.

daily_spellbook — same root cause, separate breakage

  • Deletes labels_token_standards_goerli (reads erc20_goerli, nft_goerli — both gone, so this is failing on every daily run).
  • Strips the ref from the labels_token_standards umbrella and the schema/tag metadata.
  • Leaves labels_contract_deployers_goerli alone (it reads raw goerli.creation_traces, still works).

Out of scope

  • tokens subproject has 10 tokens_goerli_* models but all are tagged static (per repo convention: "only run when modified") — they're dormant in prod, not actively breaking. Separate cleanup if anyone wants to remove them.
  • Source yml files at the repo root and the goerli chain schema itself are untouched.

Failing run for reference: https://nd058.us1.dbt.com/deploy/58579/projects/259299/runs/70471882012070/

Test plan

  • uv run dbt compile passes in hourly_spellbook (2187 models).
  • uv run dbt compile passes in daily_spellbook (2807 models).
  • CI dbt slim ci green on this branch.
  • Next prod hourly run succeeds (no more goerli failures).
  • Next prod daily run succeeds (labels_token_standards umbrella no longer skipped).

@cursor

cursor Bot commented Jun 3, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Mostly deletions and list updates in hourly_spellbook; main risk is dashboards/queries that still filter on Goerli in cross-chain spells, plus unrelated stablecoin list additions in tokens.

Overview
Removes Goerli from hourly_spellbook because sunset testnet sources no longer exist in DuneSQL and were breaking prod hourly runs (SCHEMA_NOT_FOUND / TABLE_NOT_FOUND).

Deleted: chain-specific models and tests for Safe (safe_goerli_*), address events (addresses_events_goerli_*), NFT transfers/approvals (nft_goerli_*), and Zora mints (zora_goerli_mints), plus safe_goerli schema config in dbt_project.yml.

Wired through: goerli dropped from union/ref lists and expose_spells blockchain arrays on cross-chain models (safe_*_all, nft_transfers, nft_approvals, zora_mints) and from related schema meta/tags.

Out of scope (same PR diff): tokens adds BUIDL and OUSD to tokens_ethereum_erc20_stablecoins_extended (BUIDL moved from commented yield-bearing list with a peg note).

Root-level Goerli source YAML and Goerli models in other subprojects are unchanged.

Reviewed by Cursor Bugbot for commit 170a8fe. Configure here.

@github-actions
github-actions Bot marked this pull request as draft June 3, 2026 14:22
@github-actions github-actions Bot added WIP work in progress dbt: hourly covers the hourly dbt subproject dbt: tokens covers the Tokens dbt subproject labels Jun 3, 2026
@alicecha
alicecha marked this pull request as ready for review June 3, 2026 14:39
@alicecha
alicecha requested a review from a team June 3, 2026 14:39
@github-actions github-actions Bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jun 3, 2026
@github-actions github-actions Bot added the dbt: daily covers the Daily dbt subproject label Jun 3, 2026
@alicecha alicecha changed the title fix(hourly_spellbook): drop deprecated goerli models fix: drop deprecated goerli models causing prod failures Jun 3, 2026
alicecha added 2 commits June 3, 2026 17:15
Goerli testnet was sunset and the underlying source schemas/tables
(gnosis_safe_goerli, zora_goerli, erc721_goerli, erc1155_goerli,
tokens_goerli, goerli) no longer exist in DuneSQL, causing the prod
hourly run to fail with SCHEMA_NOT_FOUND / TABLE_NOT_FOUND.

Removes the goerli models from hourly_spellbook entirely:
- safe_goerli_{singletons,safes,transactions,eth_transfers} + tests
- addresses_events_goerli_{first_activity,first_funded_by,first_token_received}
- nft_goerli_{transfers,approvals}
- zora_goerli_mints

Strips goerli refs from the umbrella aggregators (safe_*_all,
nft_transfers, nft_approvals, zora_mints) and schema/tag metadata.
Same goerli sunset as the hourly_spellbook fix: this model reads
source('erc20_goerli', 'evt_Transfer') and source('nft_goerli', 'transfers'),
both decoded schemas that no longer exist in DuneSQL. Output table
labels.token_standards_goerli had 0 query executions in 180 days
per Amplitude, so removal is safe.

Strips the ref from the labels_token_standards umbrella and the
goerli entries from the surrounding schema/tag metadata.
@alicecha
alicecha force-pushed the alice/remove-hourly-goerli-models branch from 6d00d4e to b02e2dd Compare June 3, 2026 15:15
@github-actions github-actions Bot removed the dbt: tokens covers the Tokens dbt subproject label Jun 3, 2026
@jeff-dude
jeff-dude merged commit d95e230 into main Jun 3, 2026
4 checks passed
@jeff-dude
jeff-dude deleted the alice/remove-hourly-goerli-models branch June 3, 2026 19:45
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dbt: daily covers the Daily dbt subproject dbt: hourly covers the hourly dbt subproject ready-for-review this PR development is complete, please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants