Skip to content

CI: do not log in to AWS to get manifests#9717

Merged
Pluies merged 2 commits into
mainfrom
ci-aws
Jun 4, 2026
Merged

CI: do not log in to AWS to get manifests#9717
Pluies merged 2 commits into
mainfrom
ci-aws

Conversation

@Pluies

@Pluies Pluies commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description:

Do not log into AWS during CI/CD – it doesn't work with OIDC, and we do not need it. Just retrieve the manifest directly.

@Pluies
Pluies requested a review from a team as a code owner June 4, 2026 15:51
@cursor

cursor Bot commented Jun 4, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Workflow-only change; no application, auth, or data-path logic—only how CI downloads a read-only manifest.

Overview
Removes the Configure AWS Credentials step from the reusable dbt_run workflow so CI no longer assumes an IAM role via OIDC.

The Get latest manifest step now runs aws s3 cp with --no-sign-request, fetching manifest.json from the public (or anonymously readable) S3 path without authenticated AWS credentials.

Reviewed by Cursor Bugbot for commit 70f8608. Configure here.

@github-actions
github-actions Bot marked this pull request as draft June 4, 2026 15:51
@github-actions github-actions Bot added the WIP work in progress label Jun 4, 2026
@Pluies
Pluies marked this pull request as ready for review June 4, 2026 15:51
@github-actions github-actions Bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jun 4, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Anonymous S3 copy lacks region
    • Added --region eu-west-1 to the anonymous aws s3 cp manifest download step so it targets the correct bucket region without credential-based defaults.

Create PR

Or push these changes by commenting:

@cursor push 6aebaa8814
Preview (6aebaa8814)
diff --git a/.github/workflows/dbt_run.yml b/.github/workflows/dbt_run.yml
--- a/.github/workflows/dbt_run.yml
+++ b/.github/workflows/dbt_run.yml
@@ -49,7 +49,7 @@
           echo "PROJECT_DIR=$PROJECT_DIR" >> $GITHUB_ENV
 
       - name: Get latest manifest
-        run: "aws s3 cp $S3_LOCATION/manifest.json $PROJECT_DIR/manifest.json --no-sign-request"
+        run: "aws s3 cp $S3_LOCATION/manifest.json $PROJECT_DIR/manifest.json --no-sign-request --region eu-west-1"
 
       - name: dbt dependencies
         working-directory: ${{env.PROJECT_DIR}}

You can send follow-ups to the cloud agent here.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 70f8608. Configure here.

Comment thread .github/workflows/dbt_run.yml Outdated
@Pluies
Pluies enabled auto-merge (squash) June 4, 2026 16:01
@Pluies
Pluies merged commit 751d67e into main Jun 4, 2026
7 checks passed
@Pluies
Pluies deleted the ci-aws branch June 4, 2026 16:05
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-for-review this PR development is complete, please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants