Skip to content

Bump cbor2 version#269

Open
typestring wants to merge 3 commits into
duo-labs:masterfrom
typestring:bump-cbor2-version
Open

Bump cbor2 version#269
typestring wants to merge 3 commits into
duo-labs:masterfrom
typestring:bump-cbor2-version

Conversation

@typestring
Copy link
Copy Markdown
Contributor

Hi! This PR bumps cbor2 version to address the following CVE: GHSA-3c37-wwvx-h642

This is related to issue #267.

I upgraded to cbor2 v6 and fixed the failing test caused by breaking changes introduced in the new version.
also bumping to v6 requires raising the minimum supported Python version to 3.10. Since Python 3.9 is already EOL, I don’t think this should be a major issue.

If maintaining Python 3.9 support is preferred, an alternative fix would be applying this patch instead: typestring@8385a6a

Copy link
Copy Markdown
Collaborator

@MasterKale MasterKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @typestring, this looks good to me. It's nice to see it's a relatively simple fix to support the latest cbor2 library 😌

And I'm fine with bumping the minimum supported version to 3.10. As per https://devguide.python.org/versions/ it's definitely time to move on from 3.9.

I'm still on parental leave so I can approve and merge but it'll take me a bit to cut a release with this fix. Maybe I can get a release out tonight 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants