Fix dw upgrade post-replace exit-code autoload

Author: durable-workflow-ops

src/Commands/UpgradeCommand.php

@@ -96,6 +96,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
         $asJson = $outputMode === OutputMode::JSON;
 
+        // Prime exit-code constants before any self-replacement so the current
+        // process never needs to autoload ExitCode from a swapped archive.
+        $successExit = ExitCode::SUCCESS;
+        $failureExit = ExitCode::FAILURE;
+
         $target = $this->detector !== null ? ($this->detector)() : InstallationTarget::detect(
             argv0: (string) ($_SERVER['argv'][0] ?? ''),
             pharRunning: \Phar::running(false),
@@ -122,7 +127,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'installation' => $target->toArray(),
                 'current_version' => $currentVersion,
                 'target_version' => null,
-            ], ExitCode::FAILURE);
+            ], $failureExit);
         }
 
         $catalog = $this->catalog ?? ReleaseCatalog::create();
@@ -136,7 +141,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'installation' => $target->toArray(),
                 'current_version' => $currentVersion,
                 'target_version' => null,
-            ], ExitCode::FAILURE);
+            ], $failureExit);
         }
 
         if ($target->assetName === null) {
@@ -146,7 +151,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'installation' => $target->toArray(),
                 'current_version' => $currentVersion,
                 'target_version' => $targetVersion,
-            ], ExitCode::FAILURE);
+            ], $failureExit);
         }
 
         $sameVersion = $this->versionsMatch($currentVersion, $targetVersion);
@@ -158,7 +163,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'installation' => $target->toArray(),
                 'current_version' => $currentVersion,
                 'target_version' => $targetVersion,
-            ], ExitCode::SUCCESS);
+            ], $successExit);
         }
 
         $binaryUrl = $catalog->downloadUrl($targetVersion, $target->assetName);
@@ -172,7 +177,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'target_version' => $targetVersion,
                 'asset_url' => $binaryUrl,
                 'checksum_url' => $sumsUrl,
-            ], ExitCode::SUCCESS);
+            ], $successExit);
         }
 
         if (! $target->upgradeable) {
@@ -182,7 +187,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'installation' => $target->toArray(),
                 'current_version' => $currentVersion,
                 'target_version' => $targetVersion,
-            ], ExitCode::FAILURE);
+            ], $failureExit);
         }
 
         try {
@@ -196,7 +201,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'installation' => $target->toArray(),
                 'current_version' => $currentVersion,
                 'target_version' => $targetVersion,
-            ], ExitCode::FAILURE);
+            ], $failureExit);
         }
 
         $actual = hash('sha256', $binary);
@@ -207,7 +212,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'installation' => $target->toArray(),
                 'current_version' => $currentVersion,
                 'target_version' => $targetVersion,
-            ], ExitCode::FAILURE);
+            ], $failureExit);
         }
 
         $replacer = $this->replacer ?? self::defaultReplacer(...);
@@ -221,23 +226,23 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'installation' => $target->toArray(),
                 'current_version' => $currentVersion,
                 'target_version' => $targetVersion,
-            ], ExitCode::FAILURE);
+            ], $failureExit);
         } catch (\RuntimeException $e) {
             return $this->emit($output, $asJson, [
                 'status' => 'error',
                 'reason' => $e->getMessage(),
                 'installation' => $target->toArray(),
                 'current_version' => $currentVersion,
                 'target_version' => $targetVersion,
-            ], ExitCode::FAILURE);
+            ], $failureExit);
         }
 
         return $this->emit($output, $asJson, [
             'status' => 'upgraded',
             'installation' => $target->toArray(),
             'current_version' => $currentVersion,
             'target_version' => $targetVersion,
-        ], ExitCode::SUCCESS);
+        ], $successExit);
     }
 
     private function emit(OutputInterface $output, bool $asJson, array $payload, int $exit): int

tests/Commands/UpgradeCommandTest.php

@@ -9,6 +9,7 @@
 use DurableWorkflow\Cli\Commands\UpgradePermissionException;
 use DurableWorkflow\Cli\Support\InstallationTarget;
 use DurableWorkflow\Cli\Support\ReleaseCatalog;
+use PHPUnit\Framework\Attributes\RunInSeparateProcess;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Tester\CommandTester;
@@ -196,6 +197,42 @@ public function test_full_upgrade_downloads_and_replaces_when_checksum_matches()
         self::assertSame(0755, $replaced[0]['mode']);
     }
 
+    #[RunInSeparateProcess]
+    public function test_exit_code_is_loaded_before_binary_replacement(): void
+    {
+        self::assertFalse(class_exists(\DurableWorkflow\Cli\Support\ExitCode::class, false));
+
+        $binary = 'new-binary-bytes';
+        $hash = hash('sha256', $binary);
+        $sums = "{$hash}  dw-linux-x86_64\n";
+
+        $exitCodeLoadedDuringReplace = null;
+        $replacer = function (string $path, string $bytes, int $mode) use (&$exitCodeLoadedDuringReplace): void {
+            $exitCodeLoadedDuringReplace = class_exists(\DurableWorkflow\Cli\Support\ExitCode::class, false);
+        };
+
+        $command = $this->command(
+            catalog: $this->catalog([
+                'latest-tag' => '0.1.9',
+                'sums' => $sums,
+                'asset' => $binary,
+            ]),
+            detector: fn () => new InstallationTarget(
+                kind: InstallationTarget::KIND_BINARY,
+                path: '/home/user/.local/bin/dw',
+                upgradeable: true,
+                assetName: 'dw-linux-x86_64',
+            ),
+            replacer: $replacer,
+        );
+
+        $tester = new CommandTester($command);
+        $exit = $tester->execute(['--output' => 'json']);
+
+        self::assertSame(Command::SUCCESS, $exit);
+        self::assertTrue($exitCodeLoadedDuringReplace, 'ExitCode should already be loaded before the replacer runs.');
+    }
+
     public function test_fails_on_checksum_mismatch(): void
     {
         $binary = 'mismatched-bytes';