Conformance blocker: complete sample-app coverage beyond deterministic smoke (#329)

Author: durable-workflow-ops

README.md

@@ -180,13 +180,16 @@ activities running in the worker container can reach the app. Set
 `SAMPLE_APP_CONFORMANCE_URL` when running against a different network address.
 The wrapper runs strict by default; set `SAMPLE_APP_CONFORMANCE_ALLOW_SKIPS=1`
 for local exploratory runs that should return zero while naming skipped surfaces.
-`scripts/compose-smoke.sh` is the bounded deterministic preflight: it runs the
-deterministic samples and exits after printing the blocked step, container
-status, and recent app/worker logs on failure. Set `SAMPLE_APP_SMOKE_ONLY=1`
-when a caller wants to make that intent explicit. To chain the broader public
-sample-app surface after the deterministic preflight, set
-`SAMPLE_APP_CONFORMANCE_AFTER_SMOKE=1`; otherwise run
-`scripts/compose-conformance.sh --strict` directly.
+`scripts/compose-smoke.sh` starts with the bounded deterministic preflight: it
+runs the deterministic samples and exits after printing the blocked step,
+container status, and recent app/worker logs on failure. By default, a passing
+preflight continues into the broader public sample-app conformance surface so a
+release/conformance caller does not accidentally record deterministic smoke as
+full coverage. Set `SAMPLE_APP_SMOKE_ONLY=1` when a caller intentionally wants
+only the deterministic path. Set `SAMPLE_APP_CONFORMANCE_AFTER_SMOKE=0` to
+disable the chained full surface for exploratory local runs, or run
+`scripts/compose-conformance.sh --strict` directly when the deterministic
+preflight is not needed.
 
 Tear the stack down with `docker compose down -v --remove-orphans` when
 finished. The deterministic Docker path is exercised on every push through the

scripts/compose-smoke.sh

@@ -131,7 +131,7 @@ run_sample "elapsed workflow" "app:elapsed" "Elapsed Time: [0-9]+ seconds"
 run_sample "microservice workflow" "app:microservice" "workflow_activity_other"
 run_sample "webhook workflow" "app:webhook" "Hello world"
 
-if [[ "${SAMPLE_APP_CONFORMANCE_AFTER_SMOKE:-0}" == "1" && "${SAMPLE_APP_SMOKE_ONLY:-0}" != "1" ]]; then
+if [[ "${SAMPLE_APP_CONFORMANCE_AFTER_SMOKE:-1}" == "1" && "${SAMPLE_APP_SMOKE_ONLY:-0}" != "1" ]]; then
   printf '\n==> full sample-app conformance surface\n'
   set +e
   timeout "${SAMPLE_APP_CONFORMANCE_AFTER_SMOKE_TIMEOUT_SECONDS:-1800}s" scripts/compose-conformance.sh

tests/Feature/SampleTeachingMaterialTest.php

@@ -102,7 +102,8 @@ public function test_full_conformance_harness_is_public_and_names_required_surfa
         $this->assertStringContainsString('SAMPLE_APP_CONFORMANCE_METADATA_PATH', $readme);
         $this->assertStringContainsString('DW_AGENT_OPERABILITY_SAMPLE_APP_METADATA_PATH', $readme);
         $this->assertStringContainsString('SAMPLE_APP_SMOKE_ONLY=1', $readme);
-        $this->assertStringContainsString('SAMPLE_APP_CONFORMANCE_AFTER_SMOKE=1', $readme);
+        $this->assertStringContainsString('SAMPLE_APP_CONFORMANCE_AFTER_SMOKE=0', $readme);
+        $this->assertStringContainsString('does not accidentally record deterministic smoke as', $readme);
         $this->assertStringContainsString('DURABLE_WORKFLOW_ARTIFACT_SOURCE=pinned', $readme);
         $this->assertStringContainsString('DURABLE_WORKFLOW_ARTIFACT_TUPLE_FILE=/path/to/tuple.json', $readme);
         $this->assertStringContainsString('API documentation check', $readme);

tests/Unit/ComposeScriptContractTest.php

@@ -19,9 +19,9 @@ public function test_smoke_restarts_worker_after_schema_refresh_before_samples()
         $this->assertStringContainsString('compose-smoke: all deterministic sample workflows passed', $script);
         $this->assertStringContainsString('restart_worker_after_schema_refresh()', $script);
         $this->assertStringContainsString('docker compose up -d --no-deps --force-recreate --wait worker', $script);
-        $this->assertStringContainsString('SAMPLE_APP_CONFORMANCE_AFTER_SMOKE:-0', $script);
+        $this->assertStringContainsString('SAMPLE_APP_CONFORMANCE_AFTER_SMOKE:-1', $script);
         $this->assertStringContainsString(
-            'if [[ "${SAMPLE_APP_CONFORMANCE_AFTER_SMOKE:-0}" == "1" && "${SAMPLE_APP_SMOKE_ONLY:-0}" != "1" ]]; then',
+            'if [[ "${SAMPLE_APP_CONFORMANCE_AFTER_SMOKE:-1}" == "1" && "${SAMPLE_APP_SMOKE_ONLY:-0}" != "1" ]]; then',
             $script,
         );
         $this->assertStringContainsString('SAMPLE_APP_CONFORMANCE_AFTER_SMOKE_TIMEOUT_SECONDS:-1800', $script);