Skip to content

Commit 8fed219

Browse files
Remove private tracker references from public sdk-python
Test docstrings and the CHANGELOG rationale line referenced the private tracker; rewrite them as direct prose and point pyproject Issues URL at the public durable-workflow/sdk-python issues surface so pip/PyPI users land in the right place.
1 parent 48d1c3a commit 8fed219

4 files changed

Lines changed: 8 additions & 9 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1616
via `except Exception:` or `except DurableWorkflowError:` must now either
1717
catch the class by name (e.g. `except (ActivityCancelled, WorkflowCancelled):`)
1818
or catch `BaseException`. Mirrors the standard-library precedent set by
19-
`asyncio.CancelledError` and `KeyboardInterrupt`. Rationale and upstream
20-
lesson: [zorporation/durable-workflow#441](https://github.com/zorporation/durable-workflow/issues/441).
19+
`asyncio.CancelledError` and `KeyboardInterrupt`.
2120

2221
## [0.3.0] — 2026-04-19
2322

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ docs = [
5454
Homepage = "https://github.com/durable-workflow/sdk-python"
5555
Documentation = "https://durable-workflow.github.io/docs/2.0/polyglot/python"
5656
Repository = "https://github.com/durable-workflow/sdk-python"
57-
Issues = "https://github.com/zorporation/durable-workflow/issues"
57+
Issues = "https://github.com/durable-workflow/sdk-python/issues"
5858

5959
[tool.setuptools.packages.find]
6060
where = ["src"]

tests/test_activity_context.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -203,11 +203,11 @@ async def heartbeat_activity() -> str:
203203
async def test_cancellation_survives_user_generic_except(self, mock_client: AsyncMock) -> None:
204204
"""A user activity with ``except Exception:`` must not swallow cancellation.
205205
206-
Regression guard for zorporation/durable-workflow#441: when the server
207-
signals cancellation via the heartbeat response, the activity function
208-
may have a broad ``except Exception:`` block (for logging, retry, etc.).
209-
That block must *not* catch ``ActivityCancelled``, so the worker still
210-
reports the activity as cancelled rather than completing normally.
206+
Regression guard: when the server signals cancellation via the heartbeat
207+
response, the activity function may have a broad ``except Exception:``
208+
block (for logging, retry, etc.). That block must *not* catch
209+
``ActivityCancelled``, so the worker still reports the activity as
210+
cancelled rather than completing normally.
211211
"""
212212
mock_client.heartbeat_activity_task = AsyncMock(return_value={"cancel_requested": True})
213213

tests/test_errors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class TestCancellationContract:
8989
Guards the pre-1.0 design decision that ``WorkflowCancelled`` and
9090
``ActivityCancelled`` inherit from :class:`BaseException` directly, so that
9191
user worker/activity code cannot accidentally swallow a cancellation signal
92-
in a catch-all. See zorporation/durable-workflow#441.
92+
in a catch-all.
9393
"""
9494

9595
def test_workflow_cancelled_not_caught_by_exception(self) -> None:

0 commit comments

Comments
 (0)