[cross-repo from workflow#412] server + workflow: add explicit v2 local activities support (#113)

Author: durable-workflow-ops

app/Support/WorkerProtocol.php

@@ -90,6 +90,7 @@ public static function supportedWorkflowTaskCommands(): array
      *     query_tasks: bool,
      *     activity_retry_policy: bool,
      *     activity_timeouts: bool,
+     *     local_activities: array<string, mixed>,
      *     worker_session_verbs: list<string>,
      *     worker_sessions: array<string, mixed>,
      *     child_workflow_retry_policy: bool,
@@ -126,6 +127,7 @@ public static function serverCapabilities(): array
             'query_tasks' => true,
             'activity_retry_policy' => true,
             'activity_timeouts' => true,
+            'local_activities' => self::localActivitySemantics(),
             'worker_session_verbs' => method_exists(WorkerProtocolVersion::class, 'workerSessionVerbs')
                 ? WorkerProtocolVersion::workerSessionVerbs()
                 : ['create', 'heartbeat', 'close'],
@@ -176,6 +178,52 @@ public static function serverCapabilities(): array
         ];
     }
 
+    /**
+     * @return array<string, mixed>
+     */
+    private static function localActivitySemantics(): array
+    {
+        if (method_exists(WorkerProtocolVersion::class, 'localActivitySemantics')) {
+            return WorkerProtocolVersion::localActivitySemantics();
+        }
+
+        return [
+            'schema' => 'durable-workflow.v2.local-activity.contract',
+            'version' => 1,
+            'supported' => false,
+            'api' => [
+                'functions' => ['Workflow\\V2\\localActivity'],
+                'workflow_facade' => [
+                    'Workflow\\V2\\Workflow::localActivity',
+                    'Workflow\\V2\\Workflow::executeLocalActivity',
+                ],
+                'options' => 'Workflow\\V2\\Support\\LocalActivityOptions',
+            ],
+            'execution' => [
+                'mode' => 'local',
+                'same_process' => true,
+                'ordinary_activity_task_created' => false,
+                'history_marker' => [
+                    'execution_mode' => 'local',
+                    'local_activity' => true,
+                ],
+            ],
+            'routing' => [
+                'admission' => 'activity_class_must_resolve_in_the_workflow_worker_process',
+                'queue_bypassed' => true,
+                'rejected_options' => ['connection', 'queue', 'worker_session', 'schedule_to_start_timeout'],
+            ],
+            'retry' => [
+                'cold_replay_reason' => 'cold_replay',
+            ],
+            'visibility' => [
+                'activity_execution_marker' => 'activity_options.execution_mode',
+                'history_marker' => 'payload.execution_mode',
+                'metrics_marker' => 'activities.local_*',
+            ],
+        ];
+    }
+
     /**
      * @return array{
      *     version: string,

tests/Feature/ClusterInfoTest.php

@@ -1137,6 +1137,20 @@ public function test_it_advertises_worker_command_option_capabilities_in_worker_
             ->assertOk()
             ->assertJsonPath('worker_protocol.server_capabilities.activity_retry_policy', true)
             ->assertJsonPath('worker_protocol.server_capabilities.activity_timeouts', true)
+            ->assertJsonPath(
+                'worker_protocol.server_capabilities.local_activities.schema',
+                'durable-workflow.v2.local-activity.contract',
+            )
+            ->assertJsonPath('worker_protocol.server_capabilities.local_activities.version', 1)
+            ->assertJsonPath('worker_protocol.server_capabilities.local_activities.execution.mode', 'local')
+            ->assertJsonPath(
+                'worker_protocol.server_capabilities.local_activities.execution.ordinary_activity_task_created',
+                false,
+            )
+            ->assertJsonPath(
+                'worker_protocol.server_capabilities.local_activities.routing.rejected_options',
+                ['connection', 'queue', 'worker_session', 'schedule_to_start_timeout'],
+            )
             ->assertJsonPath('worker_protocol.server_capabilities.child_workflow_retry_policy', true)
             ->assertJsonPath('worker_protocol.server_capabilities.child_workflow_timeouts', true)
             ->assertJsonPath('worker_protocol.server_capabilities.parent_close_policy', true)

tests/Feature/WorkerProtocolSuccessContractTest.php

@@ -142,6 +142,16 @@ public function test_worker_success_responses_use_worker_protocol_contract(
             ->assertJsonPath('server_capabilities.supported_workflow_task_commands.0', 'complete_workflow')
             ->assertJsonPath('server_capabilities.activity_retry_policy', true)
             ->assertJsonPath('server_capabilities.activity_timeouts', true)
+            ->assertJsonPath(
+                'server_capabilities.local_activities.schema',
+                'durable-workflow.v2.local-activity.contract',
+            )
+            ->assertJsonPath('server_capabilities.local_activities.version', 1)
+            ->assertJsonPath('server_capabilities.local_activities.execution.mode', 'local')
+            ->assertJsonPath(
+                'server_capabilities.local_activities.execution.ordinary_activity_task_created',
+                false,
+            )
             ->assertJsonPath('server_capabilities.child_workflow_retry_policy', true)
             ->assertJsonPath('server_capabilities.child_workflow_timeouts', true)
             ->assertJsonPath('server_capabilities.parent_close_policy', true)