TD-S100: Server does not prove worker protocol 1.1 feature-floor handling (#123)

Author: durable-workflow-ops

app/Http/Controllers/Api/HealthController.php

@@ -96,7 +96,7 @@ public function clusterInfo(Request $request): JsonResponse
             'child_workflow_timeouts' => true,
             'parent_close_policy' => true,
             'non_retryable_failures' => true,
-            'worker_sessions' => true,
+            'worker_sessions' => WorkerProtocol::workerSessionsSupported(),
             'history_retention' => true,
             'payload_codec_envelope' => true,
             'payload_codec_envelope_responses' => true,

tests/Feature/ClusterInfoCompatibilityTest.php

@@ -11,6 +11,7 @@
 use App\Support\WorkerProtocol;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Tests\TestCase;
+use Workflow\Serializers\CodecRegistry;
 use Workflow\V2\Support\PlatformConformanceSuite;
 use Workflow\V2\Support\PlatformProtocolSpecs;
 use Workflow\V2\Support\SurfaceStabilityContract;
@@ -524,4 +525,38 @@ public function test_worker_protocol_manifest_is_sourced_from_the_package_contra
             $response->json('worker_protocol.server_capabilities.history_compression.supported_encodings'),
         );
     }
+
+    public function test_cluster_info_advertises_worker_protocol_1_1_feature_floor_without_worker_sessions(): void
+    {
+        $protocolVersion = '1.1';
+
+        $this->assertTrue(
+            version_compare($protocolVersion, WorkerProtocol::workerSessionMinimumProtocolVersion(), '<'),
+            'This test assumes worker sessions are gated above the protocol 1.1 feature floor.',
+        );
+
+        config(['server.worker_protocol.version' => $protocolVersion]);
+
+        $response = $this->getJson('/api/cluster/info')->assertOk();
+
+        $response->assertJsonPath('worker_protocol.version', $protocolVersion)
+            ->assertJsonPath('client_compatibility.required_protocols.worker_protocol.version', $protocolVersion)
+            ->assertJsonPath('capabilities.payload_codecs', CodecRegistry::universal())
+            ->assertJsonPath('capabilities.worker_sessions', false)
+            ->assertJsonPath('worker_protocol.server_capabilities.query_tasks', true)
+            ->assertJsonPath(
+                'worker_protocol.server_capabilities.local_activities.schema',
+                'durable-workflow.v2.local-activity.contract',
+            )
+            ->assertJsonPath('worker_protocol.server_capabilities.worker_session_verbs', [])
+            ->assertJsonPath('worker_protocol.server_capabilities.worker_sessions.supported', false)
+            ->assertJsonPath(
+                'worker_protocol.server_capabilities.worker_sessions.minimum_protocol_version',
+                WorkerProtocol::workerSessionMinimumProtocolVersion(),
+            )
+            ->assertJsonPath(
+                'worker_protocol.server_capabilities.worker_sessions.unavailable_reason',
+                'worker_protocol_version_below_worker_session_minimum',
+            );
+    }
 }

tests/Feature/WorkerProtocolSuccessContractTest.php

@@ -165,6 +165,51 @@ public function test_worker_success_responses_use_worker_protocol_contract(
         }
     }
 
+    public function test_worker_protocol_1_1_registration_advertises_feature_floor_without_worker_sessions(): void
+    {
+        $protocolVersion = '1.1';
+
+        $this->assertTrue(
+            version_compare($protocolVersion, WorkerProtocol::workerSessionMinimumProtocolVersion(), '<'),
+            'This test assumes worker sessions are gated above the protocol 1.1 feature floor.',
+        );
+
+        config(['server.worker_protocol.version' => $protocolVersion]);
+
+        $response = $this->postJson('/api/worker/register', [
+            'worker_id' => 'worker-protocol-1-1',
+            'task_queue' => 'contract-queue',
+            'runtime' => 'python',
+            'sdk_version' => '1.1.0',
+        ], [
+            'X-Namespace' => 'default',
+            WorkerProtocol::HEADER => $protocolVersion,
+            ControlPlaneProtocol::HEADER => ControlPlaneProtocol::VERSION,
+        ]);
+
+        $response->assertCreated()
+            ->assertHeader(WorkerProtocol::HEADER, $protocolVersion)
+            ->assertHeaderMissing(ControlPlaneProtocol::HEADER)
+            ->assertJsonPath('protocol_version', $protocolVersion)
+            ->assertJsonPath('registered', true)
+            ->assertJsonPath('server_capabilities.query_tasks', true)
+            ->assertJsonPath(
+                'server_capabilities.local_activities.schema',
+                'durable-workflow.v2.local-activity.contract',
+            )
+            ->assertJsonPath('server_capabilities.worker_session_verbs', [])
+            ->assertJsonPath('server_capabilities.worker_sessions.supported', false)
+            ->assertJsonPath(
+                'server_capabilities.worker_sessions.minimum_protocol_version',
+                WorkerProtocol::workerSessionMinimumProtocolVersion(),
+            )
+            ->assertJsonPath(
+                'server_capabilities.worker_sessions.unavailable_reason',
+                'worker_protocol_version_below_worker_session_minimum',
+            )
+            ->assertJsonMissingPath('control_plane');
+    }
+
     public function test_leased_workflow_task_success_responses_use_worker_protocol_contract(): void
     {
         Queue::fake();