Skip to content

Commit 06a31d2

Browse files
Remove run-summary missing-age self-skip on Waterline dashboard test
Drops the markTestSkipped branch in V2DashboardStatsControllerTest::testIndexExposesRunSummaryMissingAge. The workflow rollout-safety contract pair (operator_metrics.projections.run_summaries.{oldest_missing_run_started_at,max_missing_run_age_ms}) ships in published workflow alpha 2.0.0-alpha.19, which Waterline's composer install resolves for durable-workflow/workflow: ^2.0@dev. Each key is now asserted unconditionally with assertArrayHasKey, matching the matching-role / dispatch-overdue / run-wait / stuck-lease / ready-due / claim-failed / retrying-activity / dispatch-failed removal pattern, so a rename or drop of either fails CI loudly instead of silently self-skipping.
1 parent 6f01b37 commit 06a31d2

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

tests/Feature/V2DashboardStatsControllerTest.php

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -912,14 +912,9 @@ public function testIndexExposesRunSummaryMissingAge(): void
912912
$projections = $response->json('operator_metrics.projections');
913913
$runSummaries = is_array($projections['run_summaries'] ?? null) ? $projections['run_summaries'] : null;
914914

915-
if (! is_array($runSummaries)
916-
|| ! array_key_exists('max_missing_run_age_ms', $runSummaries)
917-
|| ! array_key_exists('oldest_missing_run_started_at', $runSummaries)) {
918-
$this->markTestSkipped(
919-
'Vendored workflow package predates the run-summary projection-lag rollout-safety '
920-
. 'contract (operator_metrics.projections.run_summaries.{oldest_missing_run_started_at,max_missing_run_age_ms}).',
921-
);
922-
}
915+
$this->assertIsArray($runSummaries);
916+
$this->assertArrayHasKey('oldest_missing_run_started_at', $runSummaries);
917+
$this->assertArrayHasKey('max_missing_run_age_ms', $runSummaries);
923918

924919
$this->assertTrue(
925920
$runSummaries['oldest_missing_run_started_at'] === null

0 commit comments

Comments
 (0)