Restore legacy visibility metadata on Waterline v2 reads

Restore legacy visibility metadata on Waterline v2 reads

Author: durable-workflow-ops

app/Http/Controllers/WorkflowsController.php

@@ -23,6 +23,7 @@
 use Waterline\Support\ActionabilityContract;
 use Waterline\Support\ActionabilityVisibilityFilters;
 use Waterline\Support\CompatibilitySemantics;
+use Waterline\Support\VisibilityMetadataBridge;
 use Waterline\Waterline;
 
 class WorkflowsController extends Controller
@@ -625,6 +626,10 @@ private function listResponse(string $bucket, WorkflowRepositoryInterface $repos
     private function listItemView(WorkflowRunSummary $summary): array
     {
         $item = RunListItemView::fromSummary($summary);
+        $item['search_attributes'] = VisibilityMetadataBridge::preserve(
+            $item['search_attributes'] ?? null,
+            $summary->getRawOriginal('search_attributes'),
+        );
         $item['history_budget_indicator'] = $this->historyBudgetIndicator($item);
         $item = CompatibilitySemantics::annotateListItem($item);
         $item['actionability'] = ActionabilityContract::annotateRun($item)['actionability'];

app/Http/Resources/V2StoredWorkflowResource.php

@@ -8,6 +8,7 @@
 use Waterline\Support\ActionabilityContract;
 use Waterline\Support\CompatibilitySemantics;
 use Waterline\Support\RunDiagnostics;
+use Waterline\Support\VisibilityMetadataBridge;
 
 /**
  * @mixin WorkflowRun
@@ -26,6 +27,7 @@ public function toArray($request)
             $this->resource,
             $this->timelineLimit($request),
         );
+        $detail = $this->withLegacyVisibilityMetadata($detail);
         $detail = $this->withTimelineWindow($detail, $request);
         $detail['run_diagnostics'] = app(RunDiagnostics::class)->forRun($this->resource, $detail);
         $detail = CompatibilitySemantics::annotateRun($detail);
@@ -64,6 +66,29 @@ private function withTimelineWindow(array $detail, $request): array
         return $detail;
     }
 
+    /**
+     * @param array<string, mixed> $detail
+     *
+     * @return array<string, mixed>
+     */
+    private function withLegacyVisibilityMetadata(array $detail): array
+    {
+        $summary = $this->resource->summary;
+
+        $detail['memo'] = VisibilityMetadataBridge::preserve(
+            $detail['memo'] ?? null,
+            $this->resource->getRawOriginal('memo'),
+            $this->resource->instance?->getRawOriginal('memo'),
+        );
+        $detail['search_attributes'] = VisibilityMetadataBridge::preserve(
+            $detail['search_attributes'] ?? null,
+            $summary?->getRawOriginal('search_attributes'),
+            $this->resource->getRawOriginal('search_attributes'),
+        );
+
+        return $detail;
+    }
+
     private function timelineLimit($request): ?int
     {
         $requested = $request->query('history_limit', self::DEFAULT_TIMELINE_WINDOW);

app/Support/VisibilityMetadataBridge.php

@@ -0,0 +1,47 @@
+<?php
+
+namespace Waterline\Support;
+
+final class VisibilityMetadataBridge
+{
+    /**
+     * Preserve legacy JSON visibility metadata when the resolved workflow package
+     * returns an empty typed view for persisted runs or summaries.
+     *
+     * @return array<string, mixed>
+     */
+    public static function preserve(mixed $current, mixed ...$legacyCandidates): array
+    {
+        if (is_array($current) && $current !== []) {
+            return $current;
+        }
+
+        foreach ($legacyCandidates as $candidate) {
+            $decoded = self::decode($candidate);
+
+            if ($decoded !== []) {
+                return $decoded;
+            }
+        }
+
+        return is_array($current) ? $current : [];
+    }
+
+    /**
+     * @return array<string, mixed>
+     */
+    private static function decode(mixed $value): array
+    {
+        if (is_array($value)) {
+            return $value;
+        }
+
+        if (! is_string($value) || $value === '') {
+            return [];
+        }
+
+        $decoded = json_decode($value, true);
+
+        return is_array($decoded) ? $decoded : [];
+    }
+}

tests/Feature/V2DashboardWorkflowListTest.php

@@ -61,6 +61,9 @@ public function testRunningFlowsUseConfiguredRunSummaryModel(): void
             'class' => 'WorkflowClass',
             'workflow_type' => 'workflow.test',
             'business_key' => 'configured-list-business',
+            'search_attributes' => [
+                'customer_tier' => 'gold',
+            ],
             'status' => RunStatus::Waiting->value,
             'status_bucket' => 'running',
             'started_at' => $startedAt,
@@ -77,6 +80,7 @@ public function testRunningFlowsUseConfiguredRunSummaryModel(): void
             ->assertJsonPath('data.0.id', $run->id)
             ->assertJsonPath('data.0.business_key', 'configured-list-business')
             ->assertJsonPath('data.0.workflow_type', 'workflow.test')
+            ->assertJsonPath('data.0.search_attributes.customer_tier', 'gold')
             ->assertJsonPath('data.0.actionability.schema', 'waterline.actionability')
             ->assertJsonPath('data.0.actionability.repair_state', 'unknown')
             ->assertJsonPath('visibility_filters.actionability_contract.version', 1)
@@ -1156,6 +1160,7 @@ private function createConfiguredSummaryTable(): void
             $table->string('class');
             $table->string('workflow_type');
             $table->string('business_key')->nullable();
+            $table->json('search_attributes')->nullable();
             $table->string('declared_entry_mode')->nullable();
             $table->string('declared_contract_source')->nullable();
             $table->boolean('repair_attention')->default(false);

tests/Feature/V2DashboardWorkflowTest.php

@@ -1432,6 +1432,9 @@ public function testShowUsesConfiguredSummaryAndHistoryModels(): void
                     'id' => 123,
                 ],
             ],
+            'search_attributes' => [
+                'customer_tier' => 'gold',
+            ],
             'arguments' => Serializer::serialize([]),
             'connection' => 'redis',
             'queue' => 'default',
@@ -1490,6 +1493,7 @@ public function testShowUsesConfiguredSummaryAndHistoryModels(): void
             ->assertJsonPath('business_key', 'configured-waterline-business')
             ->assertJsonPath('memo.customer.name', 'Taylor')
             ->assertJsonPath('memo.order.id', 123)
+            ->assertJsonPath('search_attributes.customer_tier', 'gold')
             ->assertJsonPath('declared_contract_source', 'durable_history')
             ->assertJsonPath('declared_signals.0', 'configured-waterline-signal')
             ->assertJsonPath('workflow_definition_fingerprint', 'configured-waterline-fingerprint');