Make Waterline repair state filters mutually exclusive

Author: durable-workflow-ops

app/Support/ActionabilityContract.php

@@ -119,10 +119,15 @@ private static function annotateEvidence(array $row): array
      */
     private static function runActionability(array $payload): array
     {
-        $canRepair = ($payload['can_repair'] ?? null) === true;
         $blockedReason = self::stringValue($payload['repair_blocked_reason'] ?? null);
         $statusBucket = self::stringValue($payload['status_bucket'] ?? null);
         $closedReason = self::stringValue($payload['closed_reason'] ?? null);
+        $canRepair = ($payload['can_repair'] ?? null) === true
+            || (
+                ($payload['repair_attention'] ?? null) === true
+                && $blockedReason === null
+                && $statusBucket === 'running'
+            );
 
         $repairState = match (true) {
             $canRepair => 'repairable',

app/Support/ActionabilityVisibilityFilters.php

@@ -176,6 +176,7 @@ private static function applyRepairState(Builder $query, mixed $repairState): Bu
                 }),
             'unknown' => $query
                 ->where('status_bucket', 'running')
+                ->where('repair_attention', false)
                 ->whereNull('repair_blocked_reason'),
             default => $query,
         };

tests/Feature/V2DashboardWorkflowListTest.php

@@ -654,6 +654,13 @@ public function testV2RunningRepairStateFilterCanSelectUnknownActionability(): v
             Carbon::parse('2022-01-01 12:05:00'),
             Carbon::parse('2022-01-01 12:05:00'),
         );
+        $repairable = $this->createRunningSummary(
+            'repairable-repair-instance',
+            'run-repairable-repair',
+            Carbon::parse('2022-01-01 12:07:00'),
+            Carbon::parse('2022-01-01 12:07:00'),
+            repairAttention: true,
+        );
         $this->createRunningSummary(
             'blocked-repair-instance',
             'run-blocked-repair',
@@ -669,6 +676,13 @@ public function testV2RunningRepairStateFilterCanSelectUnknownActionability(): v
             ->assertJsonPath('data.0.id', $unknown->id)
             ->assertJsonPath('data.0.actionability.repair_state', 'unknown')
             ->assertJsonPath('visibility_filters.applied.repair_state', 'unknown');
+
+        $this->get('/waterline/api/flows/running?repair_state=repairable')
+            ->assertOk()
+            ->assertJsonCount(1, 'data')
+            ->assertJsonPath('data.0.id', $repairable->id)
+            ->assertJsonPath('data.0.actionability.repair_state', 'repairable')
+            ->assertJsonPath('visibility_filters.applied.repair_state', 'repairable');
     }
 
     public function testV2SavedViewsCanBeUpdatedAndDeleted(): void