Skip to content

Commit ab3d514

Browse files
Remove dispatch-failed age self-skip on Waterline dashboard test
Drops the markTestSkipped branch in V2DashboardStatsControllerTest::testIndexExposesDispatchFailedAge. The workflow rollout-safety contract pair (operator_metrics.tasks.{oldest_dispatch_failed_at,max_dispatch_failed_age_ms}) ships in published workflow alpha 2.0.0-alpha.18, which Waterline's composer install resolves for durable-workflow/workflow: ^2.0@dev. Each key is now asserted unconditionally with assertArrayHasKey, matching the matching-role / dispatch-overdue / run-wait / stuck-lease / ready-due / claim-failed / retrying-activity removal pattern, so a rename or drop of either fails CI loudly instead of silently self-skipping.
1 parent d2d9cdf commit ab3d514

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

tests/Feature/V2DashboardStatsControllerTest.php

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -887,14 +887,9 @@ public function testIndexExposesDispatchFailedAge(): void
887887

888888
$tasks = $response->json('operator_metrics.tasks');
889889

890-
if (! is_array($tasks)
891-
|| ! array_key_exists('max_dispatch_failed_age_ms', $tasks)
892-
|| ! array_key_exists('oldest_dispatch_failed_at', $tasks)) {
893-
$this->markTestSkipped(
894-
'Vendored workflow package predates the dispatch-failed age rollout-safety '
895-
. 'contract (operator_metrics.tasks.{oldest_dispatch_failed_at,max_dispatch_failed_age_ms}).',
896-
);
897-
}
890+
$this->assertIsArray($tasks);
891+
$this->assertArrayHasKey('oldest_dispatch_failed_at', $tasks);
892+
$this->assertArrayHasKey('max_dispatch_failed_age_ms', $tasks);
898893

899894
$this->assertTrue(
900895
$tasks['oldest_dispatch_failed_at'] === null

0 commit comments

Comments
 (0)