Skip to content

Commit d2d9cdf

Browse files
Remove claim-failed and retrying-activity age self-skips on Waterline dashboard tests
Drops the `markTestSkipped` branches in `V2DashboardStatsControllerTest::testIndexExposesClaimFailedAge` and `V2DashboardStatsControllerTest::testIndexExposesRetryingActivityAge`. The two workflow rollout-safety contract pairs (`operator_metrics.tasks.{oldest_claim_failed_at,max_claim_failed_age_ms}` and `operator_metrics.activities.{oldest_retrying_started_at,max_retrying_age_ms}`) both ship in published workflow alpha 2.0.0-alpha.17, which Waterline's `composer install --prefer-stable` resolves for `durable-workflow/workflow: ^2.0@dev`. Each of the four keys is now asserted unconditionally with `assertArrayHasKey`, matching the matching-role / dispatch-overdue / run-wait / stuck-lease / ready-due removal pattern, so a rename or drop of any of them fails CI loudly instead of silently self-skipping.
1 parent cf0e9af commit d2d9cdf

1 file changed

Lines changed: 6 additions & 16 deletions

File tree

tests/Feature/V2DashboardStatsControllerTest.php

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -839,14 +839,9 @@ public function testIndexExposesRetryingActivityAge(): void
839839

840840
$activities = $response->json('operator_metrics.activities');
841841

842-
if (! is_array($activities)
843-
|| ! array_key_exists('max_retrying_age_ms', $activities)
844-
|| ! array_key_exists('oldest_retrying_started_at', $activities)) {
845-
$this->markTestSkipped(
846-
'Vendored workflow package predates the retrying-activity age rollout-safety '
847-
. 'contract (operator_metrics.activities.{oldest_retrying_started_at,max_retrying_age_ms}).',
848-
);
849-
}
842+
$this->assertIsArray($activities);
843+
$this->assertArrayHasKey('oldest_retrying_started_at', $activities);
844+
$this->assertArrayHasKey('max_retrying_age_ms', $activities);
850845

851846
$this->assertTrue(
852847
$activities['oldest_retrying_started_at'] === null
@@ -868,14 +863,9 @@ public function testIndexExposesClaimFailedAge(): void
868863

869864
$tasks = $response->json('operator_metrics.tasks');
870865

871-
if (! is_array($tasks)
872-
|| ! array_key_exists('max_claim_failed_age_ms', $tasks)
873-
|| ! array_key_exists('oldest_claim_failed_at', $tasks)) {
874-
$this->markTestSkipped(
875-
'Vendored workflow package predates the claim-failed age rollout-safety '
876-
. 'contract (operator_metrics.tasks.{oldest_claim_failed_at,max_claim_failed_age_ms}).',
877-
);
878-
}
866+
$this->assertIsArray($tasks);
867+
$this->assertArrayHasKey('oldest_claim_failed_at', $tasks);
868+
$this->assertArrayHasKey('max_claim_failed_age_ms', $tasks);
879869

880870
$this->assertTrue(
881871
$tasks['oldest_claim_failed_at'] === null

0 commit comments

Comments
 (0)