Skip to content

Commit dfe3bb4

Browse files
Remove activity timeout-overdue rollup self-skip on Waterline dashboard test
Drops the markTestSkipped branch in V2DashboardStatsControllerTest::testIndexExposesActivityTimeoutOverdueRollup. The workflow rollout-safety contract triple (operator_metrics.activities.{timeout_overdue,oldest_timeout_overdue_at,max_timeout_overdue_age_ms}) ships in published workflow alpha 2.0.0-alpha.21, which Waterline's composer install resolves for durable-workflow/workflow: ^2.0@dev. Each key is now asserted unconditionally with assertArrayHasKey, matching the matching-role / dispatch-overdue / run-wait / stuck-lease / ready-due / claim-failed / retrying-activity / dispatch-failed / run-summary missing-age / backend-severity removal pattern, so a rename or drop fails CI loudly instead of silently self-skipping.
1 parent 5392264 commit dfe3bb4

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

tests/Feature/V2DashboardStatsControllerTest.php

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1006,15 +1006,9 @@ public function testIndexExposesActivityTimeoutOverdueRollup(): void
10061006
$activities = $response->json('operator_metrics.activities');
10071007

10081008
$this->assertIsArray($activities);
1009-
1010-
if (! array_key_exists('timeout_overdue', $activities)
1011-
|| ! array_key_exists('oldest_timeout_overdue_at', $activities)
1012-
|| ! array_key_exists('max_timeout_overdue_age_ms', $activities)) {
1013-
$this->markTestSkipped(
1014-
'Vendored workflow package predates the activity timeout-overdue rollup '
1015-
. '(operator_metrics.activities.{timeout_overdue,oldest_timeout_overdue_at,max_timeout_overdue_age_ms}).',
1016-
);
1017-
}
1009+
$this->assertArrayHasKey('timeout_overdue', $activities);
1010+
$this->assertArrayHasKey('oldest_timeout_overdue_at', $activities);
1011+
$this->assertArrayHasKey('max_timeout_overdue_age_ms', $activities);
10181012

10191013
$this->assertIsInt($activities['timeout_overdue']);
10201014
$this->assertGreaterThanOrEqual(0, $activities['timeout_overdue']);

0 commit comments

Comments
 (0)