Skip to content

Commit ee8fcbd

Browse files
Remove stuck-lease and ready-due self-skips on Waterline dashboard tests
Published workflow 2.0.0-alpha.14+ ships stuck-lease age keys (operator_metrics.tasks.oldest_lease_expired_at / max_lease_expired_age_ms) and alpha.15 ships ready-due age keys (operator_metrics.tasks.oldest_ready_due_at / max_ready_due_age_ms). The compatibility cushions in testIndexExposesStuckLeaseAge and testIndexExposesReadyDueAge are no longer needed and would silently mask a rename or drop of any of the four keys. Replaces the markTestSkipped branches with assertArrayHasKey so the shape assertions run unconditionally on every Waterline CI build.
1 parent 815e070 commit ee8fcbd

1 file changed

Lines changed: 4 additions & 16 deletions

File tree

tests/Feature/V2DashboardStatsControllerTest.php

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -742,14 +742,8 @@ public function testIndexExposesStuckLeaseAge(): void
742742
$tasks = $response->json('operator_metrics.tasks');
743743

744744
$this->assertIsArray($tasks);
745-
746-
if (! array_key_exists('max_lease_expired_age_ms', $tasks)
747-
|| ! array_key_exists('oldest_lease_expired_at', $tasks)) {
748-
$this->markTestSkipped(
749-
'Vendored workflow package predates the stuck-lease age rollout-safety contract '
750-
. '(operator_metrics.tasks.oldest_lease_expired_at / max_lease_expired_age_ms).',
751-
);
752-
}
745+
$this->assertArrayHasKey('oldest_lease_expired_at', $tasks);
746+
$this->assertArrayHasKey('max_lease_expired_age_ms', $tasks);
753747

754748
$this->assertTrue(
755749
$tasks['oldest_lease_expired_at'] === null
@@ -772,14 +766,8 @@ public function testIndexExposesReadyDueAge(): void
772766
$tasks = $response->json('operator_metrics.tasks');
773767

774768
$this->assertIsArray($tasks);
775-
776-
if (! array_key_exists('max_ready_due_age_ms', $tasks)
777-
|| ! array_key_exists('oldest_ready_due_at', $tasks)) {
778-
$this->markTestSkipped(
779-
'Vendored workflow package predates the ready-due age rollout-safety contract '
780-
. '(operator_metrics.tasks.oldest_ready_due_at / max_ready_due_age_ms).',
781-
);
782-
}
769+
$this->assertArrayHasKey('oldest_ready_due_at', $tasks);
770+
$this->assertArrayHasKey('max_ready_due_age_ms', $tasks);
783771

784772
$this->assertTrue(
785773
$tasks['oldest_ready_due_at'] === null

0 commit comments

Comments
 (0)