Commit fc80eb1
committed
Bind default WorkflowRepositoryInterface in package provider
On a fresh composer install, only the package's WaterlineServiceProvider
is auto-loaded. The host app has not yet published or registered its own
WaterlineApplicationServiceProvider subclass, so the
WorkflowRepositoryInterface binding — previously defined only in
WaterlineApplicationServiceProvider::register() — is absent. Any request
to /waterline/api/stats or the flow list endpoints hits a 500 with
"Target [Waterline\Repositories\Workflow\Interfaces\WorkflowRepositoryInterface]
is not instantiable".
Move the default resolver binding into the package provider's register()
method using bindIf. A published WaterlineApplicationServiceProvider
subclass that binds its own implementation still takes precedence
because bindIf defers to any existing binding.
Also mirror the Workflow\Models\Model class alias shim so both the
package provider and the Application provider remain safe to register in
either order. The new testPackageRegisterBindsDefaultRepositoryWithoutApplicationProvider
covers the fresh-install path and testPackageRegisterLeavesHostAppBindingInPlace
covers the user-override path.1 parent f138303 commit fc80eb1
2 files changed
Lines changed: 76 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
7 | 17 | | |
| 18 | + | |
8 | 19 | | |
9 | 20 | | |
10 | 21 | | |
| |||
112 | 123 | | |
113 | 124 | | |
114 | 125 | | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
115 | 161 | | |
116 | 162 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
71 | 101 | | |
72 | 102 | | |
73 | 103 | | |
| |||
0 commit comments