Improve test coverage (#227)

Author: rmcdaniel

tests/Fixtures/TestThrowOnReturnWorkflow.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Fixtures;
+
+use Workflow\Workflow;
+
+class TestThrowOnReturnWorkflow extends Workflow
+{
+    public function execute()
+    {
+        return new class() {
+            public function valid()
+            {
+                return false;
+            }
+        };
+    }
+}

tests/Fixtures/TestYieldNonPromiseWorkflow.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Fixtures;
+
+use Workflow\Workflow;
+
+class TestYieldNonPromiseWorkflow extends Workflow
+{
+    public function execute()
+    {
+        yield 'not-a-promise';
+    }
+}

tests/Unit/WorkflowTest.php

@@ -4,13 +4,16 @@
 
 namespace Tests\Unit;
 
+use BadMethodCallException;
 use Illuminate\Support\Carbon;
 use Illuminate\Support\Facades\Event;
 use Tests\Fixtures\TestActivity;
 use Tests\Fixtures\TestChildWorkflow;
 use Tests\Fixtures\TestOtherActivity;
 use Tests\Fixtures\TestParentWorkflow;
+use Tests\Fixtures\TestThrowOnReturnWorkflow;
 use Tests\Fixtures\TestWorkflow;
+use Tests\Fixtures\TestYieldNonPromiseWorkflow;
 use Tests\TestCase;
 use Workflow\Events\WorkflowFailed;
 use Workflow\Exception;
@@ -276,4 +279,52 @@ public function testParentPending(): void
         $this->assertSame(WorkflowCompletedStatus::class, $childWorkflow->status());
         $this->assertSame('other', $childWorkflow->output());
     }
+
+    public function testThrowsWhenExecuteMethodIsMissing(): void
+    {
+        $stub = WorkflowStub::load(WorkflowStub::make(TestWorkflow::class)->id());
+        $storedWorkflow = StoredWorkflow::findOrFail($stub->id());
+        $storedWorkflow->update([
+            'arguments' => Serializer::serialize([]),
+            'status' => WorkflowPendingStatus::class,
+        ]);
+
+        $this->expectException(BadMethodCallException::class);
+        $this->expectExceptionMessage('Execute method not implemented.');
+
+        $workflow = new Workflow($storedWorkflow);
+        $workflow->handle();
+    }
+
+    public function testThrowsWhenYieldNonPromise(): void
+    {
+        $stub = WorkflowStub::load(WorkflowStub::make(TestYieldNonPromiseWorkflow::class)->id());
+        $storedWorkflow = StoredWorkflow::findOrFail($stub->id());
+        $storedWorkflow->update([
+            'arguments' => Serializer::serialize([]),
+            'status' => WorkflowPendingStatus::class,
+        ]);
+
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('something went wrong');
+
+        $workflow = new TestYieldNonPromiseWorkflow($storedWorkflow);
+        $workflow->handle();
+    }
+
+    public function testThrowsWrappedException(): void
+    {
+        $stub = WorkflowStub::load(WorkflowStub::make(TestThrowOnReturnWorkflow::class)->id());
+        $storedWorkflow = StoredWorkflow::findOrFail($stub->id());
+        $storedWorkflow->update([
+            'arguments' => Serializer::serialize([]),
+            'status' => WorkflowPendingStatus::class,
+        ]);
+
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Workflow failed.');
+
+        $workflow = new TestThrowOnReturnWorkflow($storedWorkflow);
+        $workflow->handle();
+    }
 }