TD-068: DefaultServiceControlPlane activity_execution and invocable_carrier_request dispatchers mark Started without invoking the handler (#532)

Author: durable-workflow-ops

src/V2/Support/DefaultServiceControlPlane.php

@@ -1039,7 +1039,7 @@ private function dispatchActivityExecution(
             }
         }
 
-        $this->markStarted(
+        $this->stampBindingResolution(
             $call,
             ServiceCallBindingKind::ActivityExecution->value,
             $activityExecutionId,
@@ -1103,7 +1103,7 @@ private function dispatchInvocableCarrierRequest(
             $metadata['carrier'] = $carrierName;
         }
 
-        $this->markStarted(
+        $this->stampBindingResolution(
             $call,
             ServiceCallBindingKind::InvocableCarrierRequest->value,
             $carrierRequestId,
@@ -1123,6 +1123,39 @@ private function dispatchInvocableCarrierRequest(
         ];
     }
 
+    /**
+     * Commit the resolved binding kind, target reference, linked workflow
+     * pointers, and binding-derived metadata to the durable row while leaving
+     * the call in Accepted.
+     *
+     * The Started transition belongs to the execution lane that actually picks
+     * up the activity execution or invocable carrier request; the control
+     * plane's contract for these binding kinds ends at admission. See
+     * docs/architecture/workflow-service-calls-architecture.md (Service-call
+     * lifecycle): Accepted is "Resolution committed, handler binding written,
+     * handler not yet started." Started is reserved for "Handler has begun
+     * executing the linked target reference."
+     *
+     * @param array<string, mixed> $metadata
+     */
+    private function stampBindingResolution(
+        WorkflowServiceCall $call,
+        string $bindingKind,
+        string $targetReference,
+        ?string $instanceId,
+        ?string $runId,
+        ?string $updateId,
+        array $metadata,
+    ): void {
+        $call->resolved_binding_kind = $bindingKind;
+        $call->resolved_target_reference = $targetReference;
+        $call->linked_workflow_instance_id = $instanceId;
+        $call->linked_workflow_run_id = $runId;
+        $call->linked_workflow_update_id = $updateId;
+        $call->metadata = $this->mergeMetadata($call->metadata, $metadata);
+        $call->save();
+    }
+
     /**
      * @param array<string, mixed> $metadata
      */

tests/Unit/V2/DefaultServiceControlPlaneTest.php

@@ -305,7 +305,7 @@ public function testExplicitPreAdmittedCallStillDispatchesWhenIdempotencyKeyIsPr
         $this->assertCount(1, $fakeWorkflow->starts);
     }
 
-    public function testActivityBindingMarksCallStartedWithGeneratedActivityExecutionReference(): void
+    public function testActivityBindingCommitsBindingResolutionAtAcceptanceWithoutFalselyMarkingStarted(): void
     {
         $controlPlane = new DefaultServiceControlPlane(
             new FakeServiceWorkflowControlPlane(),
@@ -330,7 +330,10 @@ public function testActivityBindingMarksCallStartedWithGeneratedActivityExecutio
         ]);
 
         $this->assertTrue($result['accepted']);
-        $this->assertSame(ServiceCallStatus::Started->value, $result['status']);
+        $this->assertSame(ServiceCallStatus::Accepted->value, $result['status']);
+        $this->assertSame(ServiceCallOutcome::Accepted->value, $result['outcome']);
+        $this->assertNotNull($result['accepted_at']);
+        $this->assertNull($result['started_at']);
         $this->assertSame(ServiceCallBindingKind::ActivityExecution->value, $result['resolved_binding_kind']);
         $this->assertNotNull($result['resolved_target_reference']);
         $this->assertSame($result['resolved_target_reference'], $result['handler']['activity_execution_id']);
@@ -340,8 +343,10 @@ public function testActivityBindingMarksCallStartedWithGeneratedActivityExecutio
 
         $call = WorkflowServiceCall::query()->firstOrFail();
 
-        $this->assertSame(ServiceCallStatus::Started->value, $call->status);
+        $this->assertSame(ServiceCallStatus::Accepted->value, $call->status);
         $this->assertSame(ServiceCallOutcome::Accepted, $call->outcome);
+        $this->assertNotNull($call->accepted_at);
+        $this->assertNull($call->started_at);
         $this->assertSame($result['resolved_target_reference'], $call->resolved_target_reference);
         $this->assertSame($result['resolved_target_reference'], $call->metadata['activity_execution_id']);
         $this->assertSame('App\\Activities\\IssueInvoice', $call->metadata['activity_class']);
@@ -373,7 +378,7 @@ public function testActivityBindingFailsWhenActivityClassAndReferenceMissing():
         $this->assertSame(ServiceCallOutcome::HandlerFailed->value, $result['outcome']);
     }
 
-    public function testInvocableCarrierBindingMarksCallStartedWithGeneratedCarrierRequestReference(): void
+    public function testInvocableCarrierBindingCommitsBindingResolutionAtAcceptanceWithoutFalselyMarkingStarted(): void
     {
         $controlPlane = new DefaultServiceControlPlane(
             new FakeServiceWorkflowControlPlane(),
@@ -398,7 +403,10 @@ public function testInvocableCarrierBindingMarksCallStartedWithGeneratedCarrierR
         ]);
 
         $this->assertTrue($result['accepted']);
-        $this->assertSame(ServiceCallStatus::Started->value, $result['status']);
+        $this->assertSame(ServiceCallStatus::Accepted->value, $result['status']);
+        $this->assertSame(ServiceCallOutcome::Accepted->value, $result['outcome']);
+        $this->assertNotNull($result['accepted_at']);
+        $this->assertNull($result['started_at']);
         $this->assertSame(ServiceCallBindingKind::InvocableCarrierRequest->value, $result['resolved_binding_kind']);
         $this->assertNotNull($result['resolved_target_reference']);
         $this->assertSame($result['resolved_target_reference'], $result['handler']['carrier_request_id']);
@@ -409,8 +417,10 @@ public function testInvocableCarrierBindingMarksCallStartedWithGeneratedCarrierR
 
         $call = WorkflowServiceCall::query()->firstOrFail();
 
-        $this->assertSame(ServiceCallStatus::Started->value, $call->status);
+        $this->assertSame(ServiceCallStatus::Accepted->value, $call->status);
         $this->assertSame(ServiceCallOutcome::Accepted, $call->outcome);
+        $this->assertNotNull($call->accepted_at);
+        $this->assertNull($call->started_at);
         $this->assertSame($result['resolved_target_reference'], $call->metadata['carrier_request_id']);
         $this->assertSame('https://carrier.billing.example/handle', $call->metadata['carrier_endpoint']);
         $this->assertSame('billing.invoice.issue', $call->metadata['carrier_handler']);