Commit 684a75d
committed
Defer OperatorObservabilityRepository binding to app
The v2 customization matrix documents
Workflow\V2\Contracts\OperatorObservabilityRepository as a user-replaceable
container binding for Waterline/history-export integrations. The service
provider used singleton() to register the package default, which silently
overwrote any implementation an application bound before the workflow
provider registered (for example from an AppServiceProvider that loaded
first in bootstrap/providers.php).
Switch to singletonIf() so the package default only binds when no
implementation has been registered. Applications retain full control
whether they bind before or after the package provider.
Add testOperatorObservabilityRepositoryBindingDefersToAppBinding to
cover the pre-bound case: a custom implementation registered before
WorkflowServiceProvider::register() must survive and resolve.1 parent 8bda213 commit 684a75d
2 files changed
Lines changed: 19 additions & 1 deletion
File tree
- src/Providers
- tests/Unit/Providers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
79 | 80 | | |
80 | 81 | | |
81 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
82 | 100 | | |
83 | 101 | | |
84 | 102 | | |
| |||
0 commit comments