Revert "Carry accepted instance updates across continue-as-new run handoffs."

This reverts commit a94a173.

Author: durable-workflow-ops

docs/api-stability.md

@@ -101,31 +101,6 @@ preference; both produce identical `Support\*` Call value objects.
 Adding new static methods to the facade is an additive (non-breaking)
 change. Removing or renaming a documented method is a major change.
 
-## Continue-As-New Interleaving Contract
-
-Continue-as-new keeps one logical workflow instance while closing one run
-and creating the next run. Commands that target the logical instance keep
-their ordering and lifecycle across that boundary:
-
-- Signals are ordered by the instance message stream. A signal accepted
-  before the continue-as-new transition commits remains pending until the
-  continued run consumes it. Cursor transfer is durable and monotonic.
-- Instance-scoped updates accepted before the transition but not yet
-  applied are carried to the continued run. The update id remains stable,
-  `inspectUpdate()` follows the same lifecycle row, and the continued run
-  records the `UpdateApplied` / `UpdateCompleted` history for the update.
-- Run-targeted commands are bound to their selected run. They are not
-  retargeted to a continued run; callers that need logical-workflow
-  behavior should use the instance-scoped command surface.
-- Queries are non-durable reads. A query resolves the current run at the
-  time the query executes; if the continue-as-new transaction has already
-  committed, the query reads the continued run, otherwise it reads the
-  still-current closing run. Queries are not buffered or replayed.
-
-This contract is intentionally instance-first so external server, CLI,
-and SDK callers can reason about a stable logical workflow id without
-having to retry around the brief run handoff window.
-
 ## Pre-existing `Contracts\*` interfaces
 
 Interfaces under `Workflow\V2\Contracts\*` are the preferred extension

src/V2/Support/WorkflowExecutor.php

@@ -2329,7 +2329,6 @@ private function continueAsNew(
             $now,
             $childCallId,
         );
-        $this->transferAcceptedUpdatesToContinuedRun($run, $continuedRun);
 
         /** @var WorkflowLink $link */
         $link = WorkflowLink::query()->create([
@@ -2528,54 +2527,6 @@ private function continueAsNew(
         return $continuedTask;
     }
 
-    private function transferAcceptedUpdatesToContinuedRun(WorkflowRun $closingRun, WorkflowRun $continuedRun): void
-    {
-        $updates = WorkflowUpdate::query()
-            ->where('workflow_run_id', $closingRun->id)
-            ->where('target_scope', 'instance')
-            ->where('status', UpdateStatus::Accepted->value)
-            ->whereNull('workflow_sequence')
-            ->lockForUpdate()
-            ->get();
-
-        foreach ($updates as $update) {
-            if (! $update instanceof WorkflowUpdate) {
-                continue;
-            }
-
-            /** @var WorkflowCommand|null $command */
-            $command = $update->workflow_command_id === null
-                ? null
-                : WorkflowCommand::query()
-                    ->lockForUpdate()
-                    ->find($update->workflow_command_id);
-
-            $update->forceFill([
-                'workflow_run_id' => $continuedRun->id,
-                'resolved_workflow_run_id' => $continuedRun->id,
-            ])->save();
-
-            if ($command instanceof WorkflowCommand
-                && $command->command_type === CommandType::Update
-                && $command->status === CommandStatus::Accepted
-            ) {
-                $command->forceFill([
-                    'workflow_run_id' => $continuedRun->id,
-                    'resolved_workflow_run_id' => $continuedRun->id,
-                ])->save();
-            }
-
-            WorkflowHistoryEvent::record($continuedRun, HistoryEventType::UpdateAccepted, [
-                'workflow_command_id' => $command?->id,
-                'update_id' => $update->id,
-                'workflow_instance_id' => $continuedRun->workflow_instance_id,
-                'workflow_run_id' => $continuedRun->id,
-                'update_name' => $update->update_name,
-                'arguments' => $update->arguments,
-            ], null, $command);
-        }
-    }
-
     private function completeRun(WorkflowRun $run, WorkflowTask $task, mixed $result): void
     {
         $serializedOutput = Serializer::serializeWithCodec($run->payload_codec, $result);

tests/Feature/V2/V2MessageCursorContinueAsNewTest.php

@@ -17,7 +17,6 @@
 use Workflow\V2\Models\WorkflowInstance;
 use Workflow\V2\Models\WorkflowRun;
 use Workflow\V2\Models\WorkflowTask;
-use Workflow\V2\Models\WorkflowUpdate;
 use Workflow\V2\Support\MessageStreamCursor;
 use Workflow\V2\WorkflowStub;
 
@@ -151,99 +150,6 @@ public function testMultipleSignalsBeforeContinueAsNewTransferCursorCorrectly():
         $this->assertSame('Alice', $workflow->output()['name']);
     }
 
-    public function testAcceptedInstanceUpdateTransfersThroughContinueAsNew(): void
-    {
-        Queue::fake();
-
-        $workflow = WorkflowStub::make(TestConfiguredContinueSignalWorkflow::class, 'cursor-continue-update-1');
-        $workflow->start(0);
-
-        $update = $workflow->submitUpdate('mark-approved', true);
-
-        $this->assertTrue($update->accepted());
-        $this->assertSame('accepted', $update->status());
-
-        /** @var WorkflowUpdate $acceptedUpdate */
-        $acceptedUpdate = WorkflowUpdate::query()->findOrFail($update->updateId());
-        $firstRunId = $workflow->runId();
-
-        $this->assertSame($firstRunId, $acceptedUpdate->workflow_run_id);
-
-        $this->drainReadyTasks();
-
-        $this->waitFor(static fn (): bool => $workflow->refresh()->status() === 'waiting'
-            && $workflow->summary()?->wait_kind === 'signal');
-
-        $runs = WorkflowRun::query()
-            ->where('workflow_instance_id', 'cursor-continue-update-1')
-            ->orderBy('run_number')
-            ->get();
-
-        $this->assertCount(2, $runs);
-
-        $firstRun = $runs[0];
-        $secondRun = $runs[1];
-
-        $acceptedUpdate->refresh();
-
-        $this->assertSame($firstRunId, $firstRun->id);
-        $this->assertSame($secondRun->id, $acceptedUpdate->workflow_run_id);
-        $this->assertSame($secondRun->id, $acceptedUpdate->resolved_workflow_run_id);
-        $this->assertSame('completed', $acceptedUpdate->status->value);
-        $this->assertSame(1, (int) $acceptedUpdate->workflow_sequence);
-        $this->assertSame([
-            'approved' => true,
-            'count' => 1,
-        ], $acceptedUpdate->updateResult());
-
-        $command = WorkflowCommand::query()->findOrFail($update->commandId());
-
-        $this->assertSame($secondRun->id, $command->workflow_run_id);
-        $this->assertSame($secondRun->id, $command->resolved_workflow_run_id);
-
-        $this->assertSame(1, WorkflowHistoryEvent::query()
-            ->where('workflow_run_id', $firstRun->id)
-            ->where('event_type', HistoryEventType::UpdateAccepted->value)
-            ->count());
-        $this->assertSame(1, WorkflowHistoryEvent::query()
-            ->where('workflow_run_id', $secondRun->id)
-            ->where('event_type', HistoryEventType::UpdateAccepted->value)
-            ->where('workflow_command_id', $command->id)
-            ->count());
-        $this->assertSame(1, WorkflowHistoryEvent::query()
-            ->where('workflow_run_id', $secondRun->id)
-            ->where('event_type', HistoryEventType::UpdateApplied->value)
-            ->where('workflow_command_id', $command->id)
-            ->count());
-        $this->assertSame(1, WorkflowHistoryEvent::query()
-            ->where('workflow_run_id', $secondRun->id)
-            ->where('event_type', HistoryEventType::UpdateCompleted->value)
-            ->where('workflow_command_id', $command->id)
-            ->count());
-
-        $query = $workflow->query('current-approval');
-
-        $this->assertSame([
-            'approved' => true,
-            'count' => 1,
-        ], $query);
-
-        $signal = $workflow->signal('name-provided', 'Taylor');
-
-        $this->assertTrue($signal->accepted());
-
-        $this->drainReadyTasks();
-
-        $this->waitFor(static fn (): bool => $workflow->refresh()->completed());
-
-        $this->assertSame([
-            'name' => 'Taylor',
-            'approved' => true,
-            'workflow_id' => 'cursor-continue-update-1',
-            'run_id' => $secondRun->id,
-        ], $workflow->output());
-    }
-
     private function waitFor(callable $condition): void
     {
         $deadline = microtime(true) + 30;

tests/Fixtures/V2/TestConfiguredContinueSignalWorkflow.php

@@ -21,8 +21,6 @@ final class TestConfiguredContinueSignalWorkflow extends Workflow
 {
     private int $count = 0;
 
-    private bool $approved = false;
-
     public function handle(int $count = 0): mixed
     {
         $this->count = $count;
@@ -35,7 +33,6 @@ public function handle(int $count = 0): mixed
 
         return [
             'name' => $name,
-            'approved' => $this->approved,
             'workflow_id' => $this->workflowId(),
             'run_id' => $this->runId(),
         ];
@@ -50,20 +47,8 @@ public function currentCount(): int
     #[UpdateMethod('mark-approved')]
     public function approve(bool $approved): array
     {
-        $this->approved = $approved;
-
         return [
             'approved' => $approved,
-            'count' => $this->count,
-        ];
-    }
-
-    #[QueryMethod('current-approval')]
-    public function currentApproval(): array
-    {
-        return [
-            'approved' => $this->approved,
-            'count' => $this->count,
         ];
     }
 }