Inline Deferred promise returns

durable-workflow-ops · durable-workflow-ops · commit b36bd34d1ec4 · 2026-04-03T13:14:16.000Z
diff --git a/src/ActivityStub.php b/src/ActivityStub.php
@@ -89,15 +89,13 @@ public static function make($activity, ...$arguments): PromiseInterface
         if (WorkflowStub::isProbing()) {
             ++$context->index;
             WorkflowStub::setContext($context);
-            $deferred = new Deferred();
-            return $deferred->promise();
+            return (new Deferred())->promise();
         }
 
         $activity::dispatch($context->index, $context->now, $context->storedWorkflow, ...$arguments);
 
         ++$context->index;
         WorkflowStub::setContext($context);
-        $deferred = new Deferred();
-        return $deferred->promise();
+        return (new Deferred())->promise();
     }
 }
diff --git a/src/ChildWorkflowStub.php b/src/ChildWorkflowStub.php
@@ -82,8 +82,7 @@ public static function make($workflow, ...$arguments): PromiseInterface
         if (WorkflowStub::isProbing()) {
             ++$context->index;
             WorkflowStub::setContext($context);
-            $deferred = new Deferred();
-            return $deferred->promise();
+            return (new Deferred())->promise();
         }
 
         if (! $context->replaying) {
@@ -113,7 +112,6 @@ public static function make($workflow, ...$arguments): PromiseInterface
 
         ++$context->index;
         WorkflowStub::setContext($context);
-        $deferred = new Deferred();
-        return $deferred->promise();
+        return (new Deferred())->promise();
     }
 }
diff --git a/src/Traits/Awaits.php b/src/Traits/Awaits.php
@@ -24,8 +24,7 @@ public static function await($condition): PromiseInterface
 
         if (self::isProbing()) {
             ++self::$context->index;
-            $deferred = new Deferred();
-            return $deferred->promise();
+            return (new Deferred())->promise();
         }
 
         $result = $condition();
@@ -55,7 +54,6 @@ public static function await($condition): PromiseInterface
         }
 
         ++self::$context->index;
-        $deferred = new Deferred();
-        return $deferred->promise();
+        return (new Deferred())->promise();
     }
 }
diff --git a/src/Traits/Timers.php b/src/Traits/Timers.php
@@ -43,8 +43,7 @@ public static function timer(int|string|CarbonInterval $seconds): PromiseInterfa
 
             if (self::isProbing()) {
                 ++self::$context->index;
-                $deferred = new Deferred();
-                return $deferred->promise();
+                return (new Deferred())->promise();
             }
 
             if (! self::$context->replaying) {
@@ -54,8 +53,7 @@ public static function timer(int|string|CarbonInterval $seconds): PromiseInterfa
                 ]);
             } else {
                 ++self::$context->index;
-                $deferred = new Deferred();
-                return $deferred->promise();
+                return (new Deferred())->promise();
             }
         }
 
@@ -101,7 +99,6 @@ public static function timer(int|string|CarbonInterval $seconds): PromiseInterfa
         }
 
         ++self::$context->index;
-        $deferred = new Deferred();
-        return $deferred->promise();
+        return (new Deferred())->promise();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -89,15 +89,13 @@ public static function make($activity, ...$arguments): PromiseInterface`
`89`	`89`	`if (WorkflowStub::isProbing()) {`
`90`	`90`	`++$context->index;`
`91`	`91`	`WorkflowStub::setContext($context);`
`92`		`- $deferred = new Deferred();`
`93`		`- return $deferred->promise();`
	`92`	`+ return (new Deferred())->promise();`
`94`	`93`	`}`
`95`	`94`
`96`	`95`	`$activity::dispatch($context->index, $context->now, $context->storedWorkflow, ...$arguments);`
`97`	`96`
`98`	`97`	`++$context->index;`
`99`	`98`	`WorkflowStub::setContext($context);`
`100`		`- $deferred = new Deferred();`
`101`		`- return $deferred->promise();`
	`99`	`+ return (new Deferred())->promise();`
`102`	`100`	`}`
`103`	`101`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,8 +82,7 @@ public static function make($workflow, ...$arguments): PromiseInterface`
`82`	`82`	`if (WorkflowStub::isProbing()) {`
`83`	`83`	`++$context->index;`
`84`	`84`	`WorkflowStub::setContext($context);`
`85`		`- $deferred = new Deferred();`
`86`		`- return $deferred->promise();`
	`85`	`+ return (new Deferred())->promise();`
`87`	`86`	`}`
`88`	`87`
`89`	`88`	`if (! $context->replaying) {`
`@@ -113,7 +112,6 @@ public static function make($workflow, ...$arguments): PromiseInterface`
`113`	`112`
`114`	`113`	`++$context->index;`
`115`	`114`	`WorkflowStub::setContext($context);`
`116`		`- $deferred = new Deferred();`
`117`		`- return $deferred->promise();`
	`115`	`+ return (new Deferred())->promise();`
`118`	`116`	`}`
`119`	`117`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,7 @@ public static function await($condition): PromiseInterface`
`24`	`24`
`25`	`25`	`if (self::isProbing()) {`
`26`	`26`	`++self::$context->index;`
`27`		`- $deferred = new Deferred();`
`28`		`- return $deferred->promise();`
	`27`	`+ return (new Deferred())->promise();`
`29`	`28`	`}`
`30`	`29`
`31`	`30`	`$result = $condition();`
`@@ -55,7 +54,6 @@ public static function await($condition): PromiseInterface`
`55`	`54`	`}`
`56`	`55`
`57`	`56`	`++self::$context->index;`
`58`		`- $deferred = new Deferred();`
`59`		`- return $deferred->promise();`
	`57`	`+ return (new Deferred())->promise();`
`60`	`58`	`}`
`61`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,7 @@ public static function timer(int\|string\|CarbonInterval $seconds): PromiseInterfa`
`43`	`43`
`44`	`44`	`if (self::isProbing()) {`
`45`	`45`	`++self::$context->index;`
`46`		`- $deferred = new Deferred();`
`47`		`- return $deferred->promise();`
	`46`	`+ return (new Deferred())->promise();`
`48`	`47`	`}`
`49`	`48`
`50`	`49`	`if (! self::$context->replaying) {`
`@@ -54,8 +53,7 @@ public static function timer(int\|string\|CarbonInterval $seconds): PromiseInterfa`
`54`	`53`	`]);`
`55`	`54`	`} else {`
`56`	`55`	`++self::$context->index;`
`57`		`- $deferred = new Deferred();`
`58`		`- return $deferred->promise();`
	`56`	`+ return (new Deferred())->promise();`
`59`	`57`	`}`
`60`	`58`	`}`
`61`	`59`
`@@ -101,7 +99,6 @@ public static function timer(int\|string\|CarbonInterval $seconds): PromiseInterfa`
`101`	`99`	`}`
`102`	`100`
`103`	`101`	`++self::$context->index;`
`104`		`- $deferred = new Deferred();`
`105`		`- return $deferred->promise();`
	`102`	`+ return (new Deferred())->promise();`
`106`	`103`	`}`
`107`	`104`	`}`