Avoid redundant wake-ups for child workflows (#364)

Author: Copilot

src/ChildWorkflowStub.php

@@ -10,7 +10,6 @@
 use function React\Promise\resolve;
 use RuntimeException;
 use Throwable;
-use Workflow\Exceptions\TransitionNotFound;
 use Workflow\Serializers\Serializer;
 
 final class ChildWorkflowStub
@@ -86,13 +85,9 @@ public static function make($workflow, ...$arguments): PromiseInterface
                 }
             }
 
-            if ($childWorkflow->running() && ! $childWorkflow->created()) {
-                try {
-                    $childWorkflow->resume();
-                } catch (TransitionNotFound) {
-                    // already running
-                }
-            } elseif (! $childWorkflow->completed()) {
+            $runningStartedChildWorkflow = $childWorkflow->running() && ! $childWorkflow->created();
+
+            if (! $runningStartedChildWorkflow && ! $childWorkflow->completed()) {
                 $childWorkflow->startAsChild($context->storedWorkflow, $context->index, $context->now, ...$arguments);
             }
         }

tests/Unit/ChildWorkflowStubTest.php

@@ -9,7 +9,6 @@
 use Tests\Fixtures\TestParentWorkflow;
 use Tests\TestCase;
 use Workflow\ChildWorkflowStub;
-use Workflow\Exceptions\TransitionNotFound;
 use Workflow\Models\StoredWorkflow;
 use Workflow\Serializers\Serializer;
 use Workflow\States\WorkflowPendingStatus;
@@ -92,33 +91,18 @@ public function testLoadsChildWorkflow(): void
         $this->assertNull($result);
     }
 
-    public function testIgnoresTransitionNotFoundWhenChildResumeThrows(): void
+    public function testDoesNotResumeRunningStartedChildWorkflow(): void
     {
-        $childWorkflow = new class() {
-            public function running(): bool
-            {
-                return true;
-            }
-
-            public function created(): bool
-            {
-                return false;
-            }
-
-            public function resume(): void
-            {
-                throw TransitionNotFound::make('running', 'pending', StoredWorkflow::class);
-            }
-
-            public function completed(): bool
-            {
-                return false;
-            }
-
-            public function startAsChild(...$arguments): void
-            {
-            }
-        };
+        $childWorkflow = Mockery::mock();
+        $childWorkflow->shouldReceive('running')
+            ->once()
+            ->andReturn(true);
+        $childWorkflow->shouldReceive('created')
+            ->once()
+            ->andReturn(false);
+        $childWorkflow->shouldNotReceive('completed');
+        $childWorkflow->shouldNotReceive('resume');
+        $childWorkflow->shouldNotReceive('startAsChild');
 
         $storedChildWorkflow = Mockery::mock();
         $storedChildWorkflow->status = new \stdClass();